Bump version to 0.2.35: stop auto-marking tasks done on workflow completion

Workflow completion no longer auto-transitions tasks to Done. Only an
agent (via MCP tool) or human (via CLI) should mark tasks done after
verifying the work actually landed. Failed workflows still auto-block.

Author: Shooksie

Cargo.lock

@@ -1,6 +1,6 @@
 [package]
 name = "orchestrator-cli"
-version = "0.2.34"
+version = "0.2.35"
 edition = "2021"
 license = "Elastic-2.0"
 

crates/orchestrator-cli/Cargo.toml

@@ -85,9 +85,13 @@ impl DefaultProjectTickServices for CliProjectTickServices {
                 let any_success = task_workflows
                     .iter()
                     .any(|w| matches!(w.status, WorkflowStatus::Completed | WorkflowStatus::Escalated));
-                let new_status = if any_success { TaskStatus::Done } else { TaskStatus::Blocked };
-                let _ = hub.tasks().set_status(&task.id, new_status, false).await;
-                reconciled += 1;
+                // Only auto-transition to Blocked on failure. Task completion is never
+                // automatic — only an agent or human should mark a task done after
+                // verifying the work actually landed.
+                if !any_success {
+                    let _ = hub.tasks().set_status(&task.id, TaskStatus::Blocked, false).await;
+                    reconciled += 1;
+                }
             }
         }
         Ok(reconciled)

crates/orchestrator-cli/src/services/runtime/runtime_daemon/daemon_tick_executor.rs

@@ -67,7 +67,9 @@ pub async fn project_task_execution_fact(hub: Arc<dyn ServiceHub>, _root: &str,
         match status {
             WorkflowStatus::Pending | WorkflowStatus::Running | WorkflowStatus::Paused => return,
             WorkflowStatus::Completed => {
-                let _ = project_task_status(hub, task_id, TaskStatus::Done).await;
+                // Workflow completion does not auto-mark the task done.
+                // Only an agent or human should mark a task done after verifying
+                // that the work actually landed (e.g. PR merged).
                 return;
             }
             WorkflowStatus::Cancelled => {
@@ -79,7 +81,8 @@ pub async fn project_task_execution_fact(hub: Arc<dyn ServiceHub>, _root: &str,
     }
 
     if fact.success {
-        let _ = project_task_status(hub, task_id, TaskStatus::Done).await;
+        // Successful execution does not auto-mark the task done.
+        // Only an agent or human should mark a task done after verification.
         return;
     }
 
@@ -210,7 +213,7 @@ mod tests {
     }
 
     #[tokio::test]
-    async fn project_execution_fact_uses_task_projector_for_subject_kind() {
+    async fn project_execution_fact_does_not_auto_mark_task_done_on_success() {
         let hub = Arc::new(InMemoryServiceHub::new());
         upsert_task(&hub, "TASK-1", TaskStatus::Ready).await;
 
@@ -232,11 +235,11 @@ mod tests {
 
         assert!(projected);
         let updated = hub.tasks().get("TASK-1").await.expect("task should exist");
-        assert_eq!(updated.status, TaskStatus::Done);
+        assert_eq!(updated.status, TaskStatus::Ready, "task should NOT be auto-marked done");
     }
 
     #[tokio::test]
-    async fn project_execution_fact_preserves_legacy_task_fact_compatibility() {
+    async fn project_execution_fact_does_not_auto_mark_done_for_legacy_facts() {
         let hub = Arc::new(InMemoryServiceHub::new());
         upsert_task(&hub, "TASK-2", TaskStatus::Ready).await;
 
@@ -259,7 +262,7 @@ mod tests {
         assert!(projected);
         assert_eq!(execution_fact_subject_kind(&fact), Some(SUBJECT_KIND_TASK));
         let updated = hub.tasks().get("TASK-2").await.expect("task should exist");
-        assert_eq!(updated.status, TaskStatus::Done);
+        assert_eq!(updated.status, TaskStatus::Ready, "task should NOT be auto-marked done");
     }
 
     #[tokio::test]

crates/orchestrator-core/src/execution_projection.rs

@@ -23,7 +23,10 @@ pub async fn project_task_terminal_workflow_status(
 
     match workflow_status {
         WorkflowStatus::Completed => {
-            let _ = project_task_status(hub, task_id, TaskStatus::Done).await;
+            // Task completion is intentionally NOT automatic.
+            // Only an agent (via MCP tool) or a human (via CLI) should mark a task done
+            // after verifying the work actually landed. Workflow completion means the
+            // workflow ran — not that the task is finished.
         }
         WorkflowStatus::Failed | WorkflowStatus::Escalated => {
             let reason = failure_reason.unwrap_or_else(|| default_failure_reason(workflow_status));