Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add title elements for accessibility #11

Open
simison opened this issue Oct 8, 2017 · 3 comments
Open

Add title elements for accessibility #11

simison opened this issue Oct 8, 2017 · 3 comments

Comments

@simison
Copy link

simison commented Oct 8, 2017

SVG spec has <title> tag to help accessibility with screen readers. Oftentimes web developers ignore accessibility, but adding this directly to these svg files would make sure this will always be accessible for blind people:

<a href="#">
  <svg><title>Download on the app store</title> ...</svg>
</a>

Where as otherwise developers would need to do this:

<a href="#" aria-label="Download on the app store">
  <svg> ...</svg>
</a>

Anyone who pays attention to accessibility will make screen readers ignore whole svg or title tag if they want to provide an alternative text (e.g. when doing <a href="#"><svg></svg> Facebook</a>).

Small addition but would make a huge improvement for lots of folks out there. :-)

@ahmadalfy
Copy link

I would second that request. I still rely on this project daily so if the maintainer would give me access to contribute I would be happy to address this issue

@larsenwork
Copy link
Owner

larsenwork commented Jan 3, 2019

Sounds great @ahmadalfy — would you mind just doing a PR? I could also add you as maintainer if you'd prefer that.

@ahmadalfy
Copy link

Will do, no problem I will create the PR 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants