Upgrade to intervantion v3 #1189
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@driesvints The functionality works but I am not able fix the test that I wrote. The test runs fine on my local (MacOS + Herd) but fails on github actions. I suspect it's because of different environments or something similar but not sure. Should I remove the test for now so you can merge this PR? |
|
@tauseefsshah heya sorry for the long wait here.. could you maybe rebase this PR and fix the conflicts before I review? Thanks! |
driesvints
reviewed
Dec 6, 2024
|
Hey @driesvints 👋 Made the following updates:
Please review now and also what about the test I wrote? It's still failing on github actions. Should I skip/remove the test for now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #1187 using laravel's
response()method and upgrade intervention tov3.