From 7a8d2b4517bd7f3ef040d3c02a5fa2855c1e4253 Mon Sep 17 00:00:00 2001 From: Anders Jenbo Date: Sun, 9 Mar 2025 15:39:43 +0100 Subject: [PATCH 1/2] Check implementation instead of assuming it is View --- src/Watchers/ViewWatcher.php | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/src/Watchers/ViewWatcher.php b/src/Watchers/ViewWatcher.php index 664cf7951..db957a27d 100644 --- a/src/Watchers/ViewWatcher.php +++ b/src/Watchers/ViewWatcher.php @@ -6,6 +6,7 @@ use Illuminate\Contracts\View\Factory; use Illuminate\Support\Str; use Illuminate\View\View; +use Illuminate\Contracts\View\View as ViewContract; use Laravel\Telescope\IncomingEntry; use Laravel\Telescope\Telescope; use ReflectionFunction; @@ -38,15 +39,17 @@ public function recordAction($event, $data) return; } - /** @var View $view */ + /** @var ViewContract $view */ $view = $data[0]; - Telescope::recordView(IncomingEntry::make(array_filter([ - 'name' => $view->getName(), - 'path' => $this->extractPath($view), - 'data' => $this->extractKeysFromData($view), - 'composers' => $this->formatComposers($view), - ]))); + if ($view instanceof View) { + Telescope::recordView(IncomingEntry::make(array_filter([ + 'name' => $view->getName(), + 'path' => $this->extractPath($view), + 'data' => $this->extractKeysFromData($view), + 'composers' => $this->formatComposers($view), + ]))); + } } /** From 16ca3f31a28676ee2986d069d291827d7371670e Mon Sep 17 00:00:00 2001 From: Anders Jenbo Date: Sun, 9 Mar 2025 15:53:49 +0100 Subject: [PATCH 2/2] Update ViewWatcher.php --- src/Watchers/ViewWatcher.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Watchers/ViewWatcher.php b/src/Watchers/ViewWatcher.php index db957a27d..57c868d24 100644 --- a/src/Watchers/ViewWatcher.php +++ b/src/Watchers/ViewWatcher.php @@ -4,9 +4,9 @@ use Closure; use Illuminate\Contracts\View\Factory; +use Illuminate\Contracts\View\View as ViewContract; use Illuminate\Support\Str; use Illuminate\View\View; -use Illuminate\Contracts\View\View as ViewContract; use Laravel\Telescope\IncomingEntry; use Laravel\Telescope\Telescope; use ReflectionFunction;