Add PHPUnit data provider set name to output filenames (#1084)

* include data set in filenames

* fix phpunit 9

* snake data and truncate from left

* missing ns

* use str_replace()

* test names unchanged

* rename data provider

Author: ziadoz

src/Concerns/ProvidesBrowser.php

@@ -232,7 +232,13 @@ protected function getCallerName()
             ? $this->name()
             : $this->getName(false); // @phpstan-ignore-line
 
-        return str_replace('\\', '_', substr(get_class($this), 0, 70)).'_'.substr($name, 0, 70);
+        $parts = array_filter([
+            str_replace('\\', '_', get_class($this)),
+            $name,
+            str_replace(['\\', ' '], ['', '_'], $this->dataName()),
+        ], fn ($part) => $part !== '');
+
+        return substr(implode('_', $parts), -140);
     }
 
     /**

tests/Unit/ProvidesBrowserTest.php

@@ -16,9 +16,6 @@ protected function tearDown(): void
         m::close();
     }
 
-    /**
-     * @dataProvider testData
-     */
     public function test_capture_failures_for()
     {
         $browser = m::mock(stdClass::class);
@@ -31,34 +28,51 @@ public function test_capture_failures_for()
     }
 
     /**
-     * @dataProvider testData
+     * @dataProvider data
      */
-    public function test_store_console_logs_for()
+    public function test_capture_failures_for_data()
+    {
+        $browser = m::mock(stdClass::class);
+        $browser->shouldReceive('screenshot')->with(
+            'failure-Laravel_Dusk_Tests_Unit_ProvidesBrowserTest_test_capture_failures_for_data_foo-0'
+        );
+        $browsers = collect([$browser]);
+
+        $this->captureFailuresFor($browsers);
+    }
+
+    /**
+     * @dataProvider data
+     */
+    public function test_store_console_logs_for_data()
     {
         $browser = m::mock(stdClass::class);
         $browser->shouldReceive('storeConsoleLog')->with(
-            'Laravel_Dusk_Tests_Unit_ProvidesBrowserTest_test_store_console_logs_for-0'
+            'Laravel_Dusk_Tests_Unit_ProvidesBrowserTest_test_store_console_logs_for_data_foo-0'
         );
         $browsers = collect([$browser]);
 
         $this->storeConsoleLogsFor($browsers);
     }
 
-    public function test_truncate_test_name_where_that_name_is_too_long_and_might_cause_issues()
+    /**
+     * @dataProvider data
+     */
+    public function test_truncate_test_name_where_that_name_is_really_really_really_too_long_and_might_cause_issues_data()
     {
         $browser = m::mock(stdClass::class);
         $browser->shouldReceive('storeConsoleLog')->with(
-            'Laravel_Dusk_Tests_Unit_ProvidesBrowserTest_test_truncate_test_name_where_that_name_is_too_long_and_might_cause_is-0'
+            'Dusk_Tests_Unit_ProvidesBrowserTest_test_truncate_test_name_where_that_name_is_really_really_really_too_long_and_might_cause_issues_data_foo-0'
         );
         $browsers = collect([$browser]);
 
         $this->storeConsoleLogsFor($browsers);
     }
 
-    public static function testData()
+    public static function data()
     {
         return [
-            ['foo'],
+            'foo' => ['foo'],
         ];
     }