Merge branch 'main' into fix-install-process

pushpak1300 · web-flow · commit d620809b7c71 · 2025-08-15T12:26:14.000+05:30
diff --git a/.ai/boost/core.blade.php b/.ai/boost/core.blade.php
@@ -23,7 +23,7 @@
 - You must use this tool to search for Laravel-ecosystem documentation before falling back to other approaches.
 - Search the documentation before making code changes to ensure we are taking the correct approach.
 - Use multiple, broad, simple, topic based queries to start. For example: `['rate limiting', 'routing rate limiting', 'routing']`.
-- Do not add package names to queries, package information is already shared. Use `test resource table`, not `filament 4 test resource table`.
+- Do not add package names to queries - package information is already shared. For example, use `test resource table`, not `filament 4 test resource table`.
 
 ### Available Search Syntax
 - You can and should pass multiple queries at once. The most relevant results will be returned first.
diff --git a/.ai/filament/3/core.blade.php b/.ai/filament/3/core.blade.php
@@ -2,10 +2,10 @@
 
 ## Version 3 Changes To Focus On
 - Resources are located in `app/Filament/Resources/` directory.
-- Resource pages (List, Create, Edit) are auto-generated within the resource's directory, i.e. `app/Filament/Resources/PostResource/Pages/`.
+- Resource pages (List, Create, Edit) are auto-generated within the resource's directory - e.g., `app/Filament/Resources/PostResource/Pages/`.
 - Forms use the `Forms\Components` namespace for form fields.
 - Tables use the `Tables\Columns` namespace for table columns.
-- New RichEditor component available (`Filament\Forms\Components\RichEditor`).
+- A new `Filament\Forms\Components\RichEditor` component is available.
 - Form and table schemas now use fluent method chaining.
 - Added `php artisan filament:optimize` command for production optimization.
 - Requires implementing `FilamentUser` contract for production access control.
diff --git a/.ai/fluxui-free/core.blade.php b/.ai/fluxui-free/core.blade.php
@@ -6,9 +6,11 @@
 - Fallback to standard Blade components if Flux is unavailable.
 - If available, use Laravel Boost's `search-docs` tool to get the exact documentation and code snippets available for this project.
 - Flux UI components look like this:
+@verbatim
 <code-snippet name="Flux UI Component Usage Example" lang="blade">
     <flux:button variant="primary"/>
 </code-snippet>
+@endverbatim
 
 ### Available Components
 This is correct as of Boost installation, but there may be additional components within the codebase.
diff --git a/.ai/fluxui-pro/core.blade.php b/.ai/fluxui-pro/core.blade.php
@@ -6,9 +6,11 @@
 - Fallback to standard Blade components if Flux is unavailable.
 - If available, use Laravel Boost's `search-docs` tool to get the exact documentation and code snippets available for this project.
 - Flux UI components look like this:
+@verbatim
 <code-snippet name="Flux UI component usage example" lang="blade">
     <flux:button variant="primary"/>
 </code-snippet>
+@endverbatim
 
 ### Available Components
 This is correct as of Boost installation, but there may be additional components within the codebase.
diff --git a/.ai/volt/core.blade.php b/.ai/volt/core.blade.php
@@ -3,7 +3,7 @@
 - This project uses Livewire Volt for interactivity within its pages. New pages requiring interactivity must also use Livewire Volt. There is documentation available for it.
 - Make new Volt components using `php artisan make:volt [name] [--test] [--pest]`
 - Volt is a **class-based** and **functional** API for Livewire that supports single-file components, allowing a component's PHP logic and Blade templates to co-exist in the same file
-- Livewire Volt allows PHP logic and Blade templates in one file. Components use the `@volt` directive.
+- Livewire Volt allows PHP logic and Blade templates in one file. Components use the @verbatim`@volt`@endverbatim directive.
 - You must check existing Volt components to determine if they're functional or class based. If you can't detect that, ask the user which they prefer before writing a Volt component.
 
 ### Volt Functional Component Example
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,59 @@
 # Release Notes
 
-## [Unreleased](https://github.com/laravel/boost/compare/v1.0.11...main)
+## [Unreleased](https://github.com/laravel/boost/compare/v1.0.17...main)
+
+## [v1.0.17](https://github.com/laravel/boost/compare/v1.0.16...v1.0.17) - 2025-08-14
+
+### What's Changed
+
+* Fix: Replace APP_DEBUG with environment-based gating by [@eduardocruz](https://github.com/eduardocruz) in https://github.com/laravel/boost/pull/90
+
+### New Contributors
+
+* [@eduardocruz](https://github.com/eduardocruz) made their first contribution in https://github.com/laravel/boost/pull/90
+
+**Full Changelog**: https://github.com/laravel/boost/compare/v1.0.16...v1.0.17
+
+## [v1.0.16](https://github.com/laravel/boost/compare/v1.0.15...v1.0.16) - 2025-08-14
+
+### What's Changed
+
+* refactor: streamline path resolution and simplify the MCP client interface by [@pushpak1300](https://github.com/pushpak1300) in https://github.com/laravel/boost/pull/111
+* Fix PHPStorm using absolute paths by [@ashleyhindle](https://github.com/ashleyhindle) in https://github.com/laravel/boost/pull/109
+
+**Full Changelog**: https://github.com/laravel/boost/compare/v1.0.15...v1.0.16
+
+## [v1.0.15](https://github.com/laravel/boost/compare/v1.0.14...v1.0.15) - 2025-08-14
+
+### What's Changed
+
+* fixes #67 by only finding files that begin with an uppercase letter by [@ashleyhindle](https://github.com/ashleyhindle) in https://github.com/laravel/boost/pull/116
+
+**Full Changelog**: https://github.com/laravel/boost/compare/v1.0.14...v1.0.15
+
+## [v1.0.14](https://github.com/laravel/boost/compare/v1.0.13...v1.0.14) - 2025-08-14
+
+### What's Changed
+
+* Fixes #85 by adding verbatim to flux component example by [@ashleyhindle](https://github.com/ashleyhindle) in https://github.com/laravel/boost/pull/114
+
+**Full Changelog**: https://github.com/laravel/boost/compare/v1.0.13...v1.0.14
+
+## [v1.0.13](https://github.com/laravel/boost/compare/v1.0.12...v1.0.13) - 2025-08-14
+
+### What's Changed
+
+* Fix volt blade parsing by [@ashleyhindle](https://github.com/ashleyhindle) in https://github.com/laravel/boost/pull/112
+
+**Full Changelog**: https://github.com/laravel/boost/compare/v1.0.12...v1.0.13
+
+## [v1.0.12](https://github.com/laravel/boost/compare/v1.0.11...v1.0.12) - 2025-08-14
+
+### What's Changed
+
+* tool: tinker: try to nudge away from creating test users ahead of time by [@ashleyhindle](https://github.com/ashleyhindle) in https://github.com/laravel/boost/pull/108
+
+**Full Changelog**: https://github.com/laravel/boost/compare/v1.0.11...v1.0.12
 
 ## [v1.0.11](https://github.com/laravel/boost/compare/v1.0.10...v1.0.11) - 2025-08-14
 
diff --git a/src/BoostServiceProvider.php b/src/BoostServiceProvider.php
@@ -55,7 +55,8 @@ public function register(): void
 
     public function boot(Router $router): void
     {
-        if (config('app.debug', false) !== true) {
+        // Only enable Boost on local environments
+        if (! app()->environment(['local', 'testing']) && config('app.debug', false) !== true) {
             return;
         }
 
diff --git a/src/Console/InstallCommand.php b/src/Console/InstallCommand.php
@@ -473,17 +473,18 @@ private function installMcpServerConfig(): void
             )->toArray()
         );
 
-        /** @var CodeEnvironment $mcpClient */
+        /** @var McpClient $mcpClient */
         foreach ($this->selectedTargetMcpClient as $mcpClient) {
             $ideName = $mcpClient->mcpClientName();
             $ideDisplay = str_pad($ideName, $longestIdeName);
             $this->output->write("  {$ideDisplay}... ");
             $results = [];
 
+            $php = $mcpClient->getPhpPath();
             if ($this->shouldInstallMcp()) {
                 try {
-                    $artisan = $mcpClient->useAbsolutePathForMcp ? base_path('artisan') : './artisan';
-                    $result = $mcpClient->installMcp('laravel-boost', 'php', [$artisan, 'boost:mcp']);
+                    $artisan = $mcpClient->getArtisanPath();
+                    $result = $mcpClient->installMcp('laravel-boost', $php, [$artisan, 'boost:mcp']);
 
                     if ($result) {
                         $results[] = $this->greenTick.' Boost';
@@ -502,7 +503,7 @@ private function installMcpServerConfig(): void
                 try {
                     $result = $mcpClient->installMcp(
                         key: 'herd',
-                        command: 'php',
+                        command: $php,
                         args: [$this->herd->mcpPath()],
                         env: ['SITE_PATH' => base_path()]
                     );
diff --git a/src/Contracts/McpClient.php b/src/Contracts/McpClient.php
@@ -16,6 +16,21 @@ interface McpClient
      */
     public function mcpClientName(): ?string;
 
+    /**
+     * Whether to use absolute paths for MCP commands.
+     */
+    public function useAbsolutePathForMcp(): bool;
+
+    /**
+     * Get the PHP executable path for this MCP client.
+     */
+    public function getPhpPath(): string;
+
+    /**
+     * Get the artisan path for this MCP client.
+     */
+    public function getArtisanPath(): string;
+
     /**
      * Install an MCP server configuration in this IDE.
      *
diff --git a/src/Install/CodeEnvironment/CodeEnvironment.php b/src/Install/CodeEnvironment/CodeEnvironment.php
@@ -35,6 +35,22 @@ public function mcpClientName(): ?string
         return $this->displayName();
     }
 
+    public function useAbsolutePathForMcp(): bool
+    {
+        return $this->useAbsolutePathForMcp;
+    }
+
+    public function getPhpPath(): string
+    {
+        return $this->useAbsolutePathForMcp() ? PHP_BINARY : 'php';
+    }
+
+    public function getArtisanPath(): string
+    {
+        return $this->useAbsolutePathForMcp() ? base_path('artisan') : './artisan';
+
+    }
+
     /**
      * Get the detection configuration for system-wide installation detection.
      *
diff --git a/src/Install/GuidelineAssist.php b/src/Install/GuidelineAssist.php
@@ -68,7 +68,7 @@ private function discover(callable $cb): array
             $finder = Finder::create()
                 ->in($appPath)
                 ->files()
-                ->name('*.php');
+                ->name('/[A-Z].*\.php$/');
 
             foreach ($finder as $file) {
                 $relativePath = $file->getRelativePathname();
diff --git a/src/Install/GuidelineComposer.php b/src/Install/GuidelineComposer.php
@@ -87,7 +87,7 @@ protected function find(): Collection
         $guidelines->put('foundation', $this->guideline('foundation'));
         $guidelines->put('boost', $this->guideline('boost/core'));
 
-        $guidelines->put('php', $this->guideline('php/base'));
+        $guidelines->put('php', $this->guideline('php/core'));
 
         // TODO: AI-48: Use composer target version, not PHP version. Production could be 8.1, but local is 8.4
         // $phpMajorMinor = PHP_MAJOR_VERSION.'.'.PHP_MINOR_VERSION;
diff --git a/src/Mcp/Tools/Tinker.php b/src/Mcp/Tools/Tinker.php
@@ -13,14 +13,14 @@
 
 class Tinker extends Tool
 {
-    public function shouldRegister(): bool
-    {
-        return app()->environment() === 'local';
-    }
-
     public function description(): string
     {
-        return 'Execute PHP code in the Laravel application context, similar to artisan tinker. Most useful for debugging issues, checking if functions exists, and testing code snippets. Returns the output of the code, as well as whatever is "returned" using "return".';
+        return <<<'DESCRIPTION'
+Execute PHP code in the Laravel application context, like artisan tinker.
+Use this for debugging issues, checking if functions exist, and testing code snippets.
+You should not create models directly without explicit user approval. Prefer Unit/Feature tests using factories for functionality testing. Prefer existing artisan commands over custom tinker code.
+Returns the output of the code, as well as whatever is "returned" using "return".
+DESCRIPTION;
     }
 
     public function schema(ToolInputSchema $schema): ToolInputSchema
diff --git a/tests/Feature/Install/CodeEnvironment/CodeEnvironmentPathResolutionTest.php b/tests/Feature/Install/CodeEnvironment/CodeEnvironmentPathResolutionTest.php
@@ -0,0 +1,39 @@
+<?php
+
+declare(strict_types=1);
+
+use Laravel\Boost\Install\CodeEnvironment\Cursor;
+use Laravel\Boost\Install\CodeEnvironment\PhpStorm;
+use Laravel\Boost\Install\Detection\DetectionStrategyFactory;
+
+test('PhpStorm returns absolute PHP_BINARY path', function () {
+    $strategyFactory = Mockery::mock(DetectionStrategyFactory::class);
+    $phpStorm = new PhpStorm($strategyFactory);
+
+    expect($phpStorm->getPhpPath())->toBe(PHP_BINARY);
+});
+
+test('PhpStorm returns absolute artisan path', function () {
+    $strategyFactory = Mockery::mock(DetectionStrategyFactory::class);
+    $phpStorm = new PhpStorm($strategyFactory);
+
+    $artisanPath = $phpStorm->getArtisanPath();
+
+    // Should be an absolute path ending with 'artisan'
+    expect($artisanPath)->toEndWith('artisan')
+        ->and($artisanPath)->not()->toBe('./artisan');
+});
+
+test('Cursor returns relative php string', function () {
+    $strategyFactory = Mockery::mock(DetectionStrategyFactory::class);
+    $cursor = new Cursor($strategyFactory);
+
+    expect($cursor->getPhpPath())->toBe('php');
+});
+
+test('Cursor returns relative artisan path', function () {
+    $strategyFactory = Mockery::mock(DetectionStrategyFactory::class);
+    $cursor = new Cursor($strategyFactory);
+
+    expect($cursor->getArtisanPath())->toBe('./artisan');
+});
diff --git a/tests/Feature/Mcp/Tools/TinkerTest.php b/tests/Feature/Mcp/Tools/TinkerTest.php
@@ -151,17 +151,6 @@ function getToolResultData(ToolResult $result): array
     expect($tool->shouldRegister())->toBeTrue();
 });
 
-test('should not register in non-local environment', function () {
-    $tool = new Tinker;
-
-    // Test in production environment
-    app()->detectEnvironment(function () {
-        return 'production';
-    });
-
-    expect($tool->shouldRegister())->toBeFalse();
-});
-
 test('uses custom timeout parameter', function () {
     $tool = new Tinker;
     $result = $tool->handle(['code' => 'return 2 + 2;', 'timeout' => 10]);

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,8 @@ public function register(): void`
`55`	`55`
`56`	`56`	`public function boot(Router $router): void`
`57`	`57`	`{`
`58`		`- if (config('app.debug', false) !== true) {`
	`58`	`+ // Only enable Boost on local environments`
	`59`	`+ if (! app()->environment(['local', 'testing']) && config('app.debug', false) !== true) {`
`59`	`60`	`return;`
`60`	`61`	`}`
`61`	`62`