Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🛂 Improve admin/permission implementation #14

Open
Log1x opened this issue Feb 2, 2024 · 0 comments
Open

🛂 Improve admin/permission implementation #14

Log1x opened this issue Feb 2, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@Log1x
Copy link
Member

Log1x commented Feb 2, 2024

Few ideas

  • Consider introducing permission groups that get configured in config/discord.php or via a permissions() method you can override in app/Bot.php instead of just having is_admin on the User model.
    • Users could be in multiple groups.
    • Could use a wildcard * permission node for super admins.

Must have

  • Introduce some kind of override-able authorize() method for customizing admin/permission checks on commands.

Changes

  • Laracord currently has legacy behavior of adding every user who executes a command to the database. This is unnecessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Log1x