From ed904c38852af41966e9ea8836ce9c5d302b081f Mon Sep 17 00:00:00 2001 From: Steve Brown Date: Tue, 3 Mar 2020 05:44:00 +0900 Subject: [PATCH] updated bundler, rake, simplecov versions, updated tests to match, removed unused variables --- .ruby-version | 1 + dns-zone.gemspec | 6 +++--- lib/dns/zone.rb | 2 -- test/rr/record_test.rb | 2 +- 4 files changed, 5 insertions(+), 6 deletions(-) create mode 100644 .ruby-version diff --git a/.ruby-version b/.ruby-version new file mode 100644 index 0000000..24ba9a3 --- /dev/null +++ b/.ruby-version @@ -0,0 +1 @@ +2.7.0 diff --git a/dns-zone.gemspec b/dns-zone.gemspec index e9ac75b..f8ae27f 100644 --- a/dns-zone.gemspec +++ b/dns-zone.gemspec @@ -24,10 +24,10 @@ spec = Gem::Specification.new do |s| # cross platform gem dependencies #s.add_dependency('gli') #s.add_dependency('paint') - s.add_development_dependency('bundler', '~> 1.0') - s.add_development_dependency('rake', '>= 9.0') + s.add_development_dependency('bundler', '~> 2.0') + s.add_development_dependency('rake', '>= 13.0') s.add_development_dependency('minitest', '~> 5.0') - s.add_development_dependency('simplecov', '~> 0.7.1') + s.add_development_dependency('simplecov', '~> 0.18') s.add_development_dependency('yard', '~> 0.8') s.add_development_dependency('inch', '~> 0.6') s.add_development_dependency('guard-minitest', '~> 2.0') diff --git a/lib/dns/zone.rb b/lib/dns/zone.rb index 8e6fcee..991ef34 100644 --- a/lib/dns/zone.rb +++ b/lib/dns/zone.rb @@ -131,7 +131,6 @@ def self.extract_entries(string) # with a ";" (semicolon). entries = [] - mode = :line entry = '' parentheses_ref_count = 0 @@ -151,7 +150,6 @@ def self.extract_entries(string) has_quotes = quotes > 0 parentheses = entry.count('()') - has_parentheses = parentheses > 0 if has_quotes character_strings = entry.scan(/("(?:[^"\\]+|\\.)*")/).join(' ') diff --git a/test/rr/record_test.rb b/test/rr/record_test.rb index 3be879b..be225dc 100644 --- a/test/rr/record_test.rb +++ b/test/rr/record_test.rb @@ -5,7 +5,7 @@ class RR_Record_Test < DNS::Zone::TestCase def test_rr_record_defaults rr = DNS::Zone::RR::Record.new assert_equal '@', rr.label, 'label is @, by default' - assert_equal nil, rr.ttl, 'ttl is nil, by default' + assert_nil rr.ttl, 'ttl is nil, by default' end def test_rr_record_with_label