Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support HHVM #50

Open
lanthaler opened this issue Jan 8, 2014 · 5 comments
Open

Support HHVM #50

lanthaler opened this issue Jan 8, 2014 · 5 comments
Labels
enhancement

Comments

@lanthaler
Copy link
Owner

Currently, a lot of tests fail. Investigate the reason and fix it or file a bug for HHVM.
lanthaler added a commit that referenced this issue Jan 8, 2014
@lanthaler
Allow HHVM to fail for the time being
7393531 
Issue #50 has been created to keep track of the failing tests.
@lanthaler
Copy link
Owner Author

The reason for the failing tests is that HHVM doesn't support stream notification callbacks (yet): facebook/hhvm#2903

@lanthaler
Copy link
Owner Author

Looks like PHP 7.0 fails as well. The code should be updated to work with both HHVM and PHP 7.0.

@lanthaler lanthaler changed the title Support HHVM Support HHVM and PHP 7 Dec 22, 2015
lanthaler added a commit that referenced this issue Dec 22, 2015
@lanthaler
Allow PHP 7.0 to fail for the time being
cfd0731 
Issue #50 tracks adding support for both PHP 7 and HHVM.
@zobzn
Copy link
Contributor

zobzn commented Aug 3, 2016

pull request for php7 - #73

lanthaler added a commit that referenced this issue Aug 25, 2016
@lanthaler
Merge pull request #73 from zobzn/php7
8eaca98 
Fix unit tests in PHP 7

This addresses #50
@lanthaler
Copy link
Owner Author

Thanks a lot @zobzn

@nichtich nichtich mentioned this issue Aug 25, 2017
Closed
@lanthaler lanthaler changed the title Support HHVM and PHP 7 Support HHVM Jan 28, 2018
@k00ni
Copy link
Contributor

k00ni commented Mar 3, 2020

Based on this announcement, HHVM will likely not support PHP in the future:

2018-12-03: branch cut: expect PHP code to stop working with master and nightly builds after this date

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@k00ni @lanthaler @zobzn