feat: add unit test

Author: xinqiu

langchain/vectorstores/redisearch.py

@@ -2,14 +2,15 @@
 
 import json
 import uuid
-from typing import Any, Callable, Iterable, List, Optional, Tuple
+from typing import Any, Callable, Iterable, List, Mapping, Optional
+
+import numpy as np
+from redis.commands.search.query import Query
 
 from langchain.docstore.document import Document
 from langchain.embeddings.base import Embeddings
-from langchain.vectorstores.base import VectorStore
 from langchain.utils import get_from_dict_or_env
-from redis.commands.search.query import Query
-import numpy as np
+from langchain.vectorstores.base import VectorStore
 
 
 class RediSearch(VectorStore):
@@ -80,7 +81,9 @@ def similarity_search(
             .paging(0, k)
             .dialect(2)
         )
-        params_dict = {"vector": np.array(embedding).astype(dtype=np.float32).tobytes()}
+        params_dict: Mapping[str, str] = {
+            "vector": str(np.array(embedding).astype(dtype=np.float32).tobytes())
+        }
 
         # perform vector search
         results = self.client.ft(self.index_name).search(redis_query, params_dict)
@@ -115,15 +118,14 @@ def from_texts(
                 redisearch = RediSearch.from_texts(
                     texts,
                     embeddings,
-                    redis_url="redis://username:password@localhost:6379"
+                    redisearch_url="redis://username:password@localhost:6379"
                 )
         """
         redisearch_url = get_from_dict_or_env(
             kwargs, "redisearch_url", "REDISEARCH_URL"
         )
         try:
             import redis
-            from redis.commands.search.query import Query
             from redis.commands.search.field import TextField, VectorField
             from redis.commands.search.indexDefinition import IndexDefinition, IndexType
         except ImportError:
@@ -165,7 +167,7 @@ def from_texts(
         try:
             client.ft(index_name).info()
             print("Index already exists")
-        except:
+        except: # noqa
             # Create RediSearch Index
             client.ft(index_name).create_index(
                 fields=fields,

tests/integration_tests/vectorstores/test_redisearch.py

@@ -0,0 +1,15 @@
+"""Test RediSearch functionality."""
+
+from langchain.docstore.document import Document
+from langchain.vectorstores.redisearch import RediSearch
+from tests.integration_tests.vectorstores.fake_embeddings import FakeEmbeddings
+
+
+def test_redisearch() -> None:
+    """Test end to end construction and search."""
+    texts = ["foo", "bar", "baz"]
+    docsearch = RediSearch.from_texts(
+        texts, FakeEmbeddings(), redisearch_url="redis://localhost:6379"
+    )
+    output = docsearch.similarity_search("foo", k=1)
+    assert output == [Document(page_content="foo")]