Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChatBedrock does not support deepseek R1 #352

Open
efriis opened this issue Feb 8, 2025 · 3 comments
Open

ChatBedrock does not support deepseek R1 #352

efriis opened this issue Feb 8, 2025 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@efriis
Copy link
Member

efriis commented Feb 8, 2025

Bedrock supports deepseek R1 through the invoke API: https://aws.amazon.com/blogs/machine-learning/deepseek-r1-model-now-available-in-amazon-bedrock-marketplace-and-amazon-sagemaker-jumpstart/

A case should be added to the Invoke compatible ChatBedrock case that uses the deepseek message templating (from the above blog):

ChatTemplate.DEEPSEEK: f"""You are a helpful assistant <|User|>{prompt}<|Assistant|>"""
@efriis
Copy link
Member Author

efriis commented Feb 8, 2025

cc @3coins had someone ask for this today if easy to add!

@efriis
Copy link
Member Author

efriis commented Feb 8, 2025

Would be great to get the Qwen and Llama distill ones working too! There's a chance the llama ones will fall into llama2 chat message templating if the model ID doesn't explicitly include "llama3"

https://github.com/langchain-ai/langchain-aws/blob/main/libs/aws/langchain_aws/chat_models/bedrock.py#L354

@michaelnchin michaelnchin self-assigned this Feb 8, 2025
@michaelnchin michaelnchin added the enhancement New feature or request label Feb 8, 2025
@3coins
Copy link
Collaborator

3coins commented Feb 10, 2025

Would be great to get the Qwen and Llama distill ones working too

+1, will bring this up with the team. @michaelnchin is working on the deepseek integration in #353.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants