Skip to content

Make the Sound Expressions effect default parameters/steps CODAL defaults #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
microbit-carlos opened this issue May 15, 2023 · 5 comments
Assignees
Labels
Milestone

Comments

@microbit-carlos
Copy link
Collaborator

Neither MakeCode nor MicroPython expose to the users a way to change the fx params and steps.
For consistency we should use the same values for both platforms, to be able to generate the same sounds.
In that case it makes sense to make these the default values inside CODAL instead of having both platform setting the same values.

https://github.com/microsoft/pxt/blob/5e2ff19c7d44bc659b997530c96b7ac9ad6a6551/webapp/src/components/soundEffectEditor/soundUtil.ts#L24-L42

@martinwork
Copy link
Collaborator

Reported as a Python problem in support ticket https://support.microbit.org/helpdesk/tickets/70448 (private)

@microbit-carlos microbit-carlos modified the milestones: v0.2.64, v0.2.65 Feb 13, 2024
@microbit-carlos
Copy link
Collaborator Author

microbit-carlos commented Mar 26, 2024

@JohnVidler the preferred MicroPython solution is to set the parameters as #defines and MicroPython can use those:

@JohnVidler
Copy link
Collaborator

I've defined a few SFX defaults over in this PR, would this do the trick?

#417

@microbit-carlos
Copy link
Collaborator Author

PR has been merged, next steps is to check that MicroPython is implementing it and submitting a PR to MakeCode.

@microbit-carlos
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants