-
Notifications
You must be signed in to change notification settings - Fork 58
Make the Sound Expressions effect default parameters/steps CODAL defaults #315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Reported as a Python problem in support ticket https://support.microbit.org/helpdesk/tickets/70448 (private) |
@JohnVidler the preferred MicroPython solution is to set the parameters as #defines and MicroPython can use those: |
I've defined a few SFX defaults over in this PR, would this do the trick? |
PR has been merged, next steps is to check that MicroPython is implementing it and submitting a PR to MakeCode. |
MicroPython work tracked in: MakeCode in: This CODAL issue can be closed as complete. |
Neither MakeCode nor MicroPython expose to the users a way to change the fx params and steps.
For consistency we should use the same values for both platforms, to be able to generate the same sounds.
In that case it makes sense to make these the default values inside CODAL instead of having both platform setting the same values.
https://github.com/microsoft/pxt/blob/5e2ff19c7d44bc659b997530c96b7ac9ad6a6551/webapp/src/components/soundEffectEditor/soundUtil.ts#L24-L42
The text was updated successfully, but these errors were encountered: