Skip to content

Remove BlockExt trait from Cairo Native #1231

@FrancoGiachetta

Description

@FrancoGiachetta

Cairo Native currently maintains BlockExt as an extension for mlir's Block. This trait holds a bunch of methods which help us reduce the amount of code we need to write in order to build the mlir operations. Here is were it is currently located: https://github.com/lambdaclass/cairo_native/blob/main/src/utils/block_ext.rs

However the same trait has been added to melior crate:

This means we are unnecessarily maintaining code, since both traits don't differ in their implementation at all. Not only this but it also may generate some annoying issues while implementing libfuncs. Since there are two versions of the same trait, one could run into some incompatibilities when importing these methods.

We should try removing the the cairo_native's implementation and stick with melior's.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions