Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proc-macro2? #115

Closed
ignatenkobrain opened this issue Jan 14, 2018 · 3 comments
Closed

proc-macro2? #115

ignatenkobrain opened this issue Jan 14, 2018 · 3 comments

Comments

@ignatenkobrain
Copy link

I'm packaging systemd-manager which depends on horrorshow which depends on maud_macros in the end and right now maud_macros is nightly due to proc_macro.

Would it be possible to switch to proc-macro2 which is working under stable Rust?

https://crates.io/crates/proc-macro2

@lambda-fairy
Copy link
Owner

lambda-fairy commented Jan 20, 2018

Yes it should be possible -- see #17.

An issue with stable support is usability. Only custom derive is stable at the moment, so to use Maud under stable, you'll need to fiddle with build scripts and manual codegen. For this reason I haven't made stable support a priority yet.

Note that Horrorshow only depends on Maud for benchmarks. It should be safe to remove Maud from the dependencies as long as benchmarks are never built.

@ignatenkobrain
Copy link
Author

Oh, it seems I was blind when looking into horrorshow deps..

@lambda-fairy
Copy link
Owner

Closing as duplicate of #17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants