You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 4751a65
Browse filesBrowse the repository at this point in the historyBrowse files
fix(security): clear the critical and high advisories (#47)
* fix(security): clear the critical and high advisories
Propagated from shipkit. Five packages, all with published patches.
packages/web
sharp 0.32.5 -> ^0.35.4 The critical here is an RCE
through AVIF decoding in libheif,
which astro reaches via its
default sharp image service. The
advisory is filed against astro
with a fix of 7.2.8, but the
vulnerable code is sharp's, so
patching sharp closes it without
a two-major astro migration.
astro 5.7.13 -> ^5.15.8 Reflected XSS via server islands.
@astrojs/cloudflare 12.6.3 -> ^12.6.6
packages/opencode
minimatch 10.0.3 -> ^10.2.3
packages/console/core
mysql2 3.14.4 -> ^3.22.0 Dev scope.
root overrides
wrangler -> ^4.59.1 Transitive and dev scope.
Still open after this: two astro highs that need 6.3.3 and 6.4.6, and the
astro alert for the libheif critical, which will keep showing until astro
itself moves to 7.2.8 even though the underlying flaw is now patched. Both
need a real major migration of packages/web and belong in their own change.
`bun turbo typecheck` passes, 8 of 8 tasks.
* chore: format code
* feat(web): migrate to Astro 6, closing the remaining advisories
Astro 5.7.13 carried four advisories. sharp 0.35.4 in the previous commit
already closed the critical, because that one is an RCE through AVIF decoding
in libheif which astro only reaches via its default sharp image service. This
moves the framework itself so the other three close too.
astro ^5.15.8 -> ^6.4.8 reflected XSS via server islands
(5.15.8), reflected XSS via
unescaped slot name (6.3.3), host
header SSRF in the prerendered
error page fetch (6.4.6)
@astrojs/cloudflare ^12.6.6 -> ^13.7.0 peers astro ^6.3.0
@astrojs/starlight 0.34.3 -> ^0.40.0 0.40 is the last line that peers
astro ^6; 0.41 requires astro 7
@astrojs/solid-js 5.1.0 -> ^6.0.1
@astrojs/markdown-remark 6.3.1 -> ^6.3.11
Two things had to change for the build to work at all.
The catalog pinned vite at 7.1.4 while astro 6 needs ^7.3.2, so astro and the
cloudflare adapter resolved a nested vite while starlight and vite-plugin-solid
resolved the hoisted one. Virtual modules are registered per vite instance, so
the split meant `astro:assets`, `astro:static-paths` and `virtual:astro:app`
could not resolve and the build died in rolldown. The catalog now pins 7.3.6
and every package in the plugin chain resolves the same vite.
packages/web/wrangler.jsonc is new. @astrojs/cloudflare starts a miniflare
worker to prerender routes during the build, and without nodejs_compat that
worker cannot resolve the node builtins postcss and expressive-code import, so
prerendering failed with `No such module "chunks/path"`. Deployment is still
configured by SST in infra/app.ts; this file only affects the build.
Astro 7 was tried first and abandoned. It replaces remark/rehype with satteri,
whose worker build needs @bruits/satteri-wasm32-wasi, which bun will not
install because the package declares cpu: ["wasm32"]. Installing it by hand
gets the bundle to build and then fails prerendering with "The WASI method is
not implemented". That is an upstream problem, and astro 6 closes every
advisory anyway.
`bun turbo typecheck` passes 8 of 8. `astro build` completes, including the
pagefind index and sitemap.
---------
Co-authored-by: GitHub Action <action@github.com>
0 commit comments