Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

question(docs): update permissions App config to reflect current codebase? #9

Open
crookse-cl opened this issue Nov 20, 2023 · 1 comment
Open

question(docs): update permissions App config to reflect current codebase? #9

crookse-cl opened this issue Nov 20, 2023 · 1 comment

Comments

@crookse-cl
Copy link
Contributor

crookse-cl commented Nov 20, 2023 •
edited
Loading

Summary

While adding in the ArweaveWalletKit component without passing in the permissions config, I noticed these default permissions were set:

arweave-wallet-kit/src/components/Provider.tsx

Line 99 in 4249701

permissions: ["ACCESS_ADDRESS", "ACCESS_ALL_ADDRESSES"],

Question

Should the docs show the defaults that are set in the code or should the code default to an empty array?
@7i7o
Copy link
Contributor

7i7o commented Nov 20, 2023

IMO we should update the docs to show the defaults set in the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@7i7o @crookse-cl