Merge pull request #1714 from gumulka/conditionally_check_imxusbloader

IMXUSBDriver: conditionally check image

Author: Bastian-Krause

doc/configuration.rst

@@ -2551,6 +2551,9 @@ An :any:`IMXUSBDriver` is used to upload an image into a device in the *i.MX
 USB loader state*.
 This is useful to bootstrap a bootloader onto a device.
 This driver uses the ``imx-usb-loader`` tool from barebox.
+If your device has the ``SDP_READ_DISABLE`` fuse burnt, then reading back data
+over USB is not possible anymore, which means, that the verification of the
+image is not possible anymore. Set ``verify`` to False in this case.
 
 Binds to:
   loader:
@@ -2569,13 +2572,15 @@ Implements:
        drivers:
          IMXUSBDriver:
            image: 'mybootloaderkey'
+           verify: True
 
    images:
      mybootloaderkey: 'path/to/mybootloader.img'
 
 Arguments:
   - image (str): optional, key in :ref:`images <labgrid-device-config-images>` containing the path
     of an image to bootstrap onto the target
+  - verify (bool, default=True): optional, wether to verify the written image or not
 
 BDIMXUSBDriver
 ~~~~~~~~~~~~~~

labgrid/driver/usbloader.py

@@ -55,6 +55,7 @@ class IMXUSBDriver(Driver, BootstrapProtocol):
     }
 
     image = attr.ib(default=None)
+    verify = attr.ib(default=True, validator=attr.validators.instance_of(bool))
 
     def __attrs_post_init__(self):
         super().__attrs_post_init__()
@@ -78,9 +79,13 @@ def load(self, filename=None):
         mf = ManagedFile(filename, self.loader)
         mf.sync_to_resource()
 
+        command = [self.tool, "-p", str(self.loader.path)]
+        if self.verify:
+            command.append("-c")
+        command.append(mf.get_remote_path())
+
         processwrapper.check_output(
-            self.loader.command_prefix +
-            [self.tool, "-p", str(self.loader.path), "-c", mf.get_remote_path()],
+            self.loader.command_prefix + command,
             print_on_silent_log=True
         )