Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Powershell parsing errors #5

Closed
Raikia opened this issue Feb 8, 2018 · 6 comments
Closed

Powershell parsing errors #5

Raikia opened this issue Feb 8, 2018 · 6 comments

Comments

@Raikia
Copy link

Raikia commented Feb 8, 2018

Thanks for releasing this, it looks like there are some errors with displaying the banner though:

asdf

@l0ss
Copy link
Owner

l0ss commented Feb 9, 2018

What version of Windows/PS are you on? I do my testing on 2012R2 and 2016.

@Raikia
Copy link
Author

Raikia commented Feb 9, 2018

Windows 7 and PowerShell version 2

@l0ss
Copy link
Owner

l0ss commented Feb 9, 2018

OK, i'll have to spin up a Win7 VM and test.

@l0ss
Copy link
Owner

l0ss commented Feb 10, 2018

I've figured out how to fix the banner but oddly enough under Win7 I don't get any output.

It'll take some time to figure out why.

@l0ss
Copy link
Owner

l0ss commented Feb 10, 2018

Oh dear, it appears that the way PS handles System.Xml.XmlElement objects has changed substantially at some point and Grouper relies heavily on the new behaviour.

I'll add Win7/PS 2.0 compatibility to my TODO list but in the meantime let's just say you need to use newer Windows/PS.

@l0ss l0ss closed this as completed Feb 10, 2018
@Raikia
Copy link
Author

Raikia commented Feb 15, 2018

Yeah, honestly I think that's acceptable to just ignore it since you can export the XML and put it on an updated VM or something. Thanks for letting me know! I'd recommend throwing that into the README or printing an error or something if it detects its running on PS2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants