Add codelyzer #983

l-lin · l-lin · commit 8ab310743f0b · 2017-03-03T23:28:55.000+01:00
diff --git a/demo/src/app/advanced/dt-instance-snippet.component.ts b/demo/src/app/advanced/dt-instance-snippet.component.ts
@@ -1,7 +1,7 @@
 import { Component } from '@angular/core';
 
 @Component({
-  selector: 'dt-instance-snippet',
+  selector: 'app-dt-instance-snippet',
   template: `
   <div id="html" class="col s12 m9 l12">
     <h4 class="header">HTML</h4>
diff --git a/demo/src/app/advanced/dt-instance.component.html b/demo/src/app/advanced/dt-instance.component.html
@@ -33,7 +33,7 @@ <h4 class="header">Preview</h4>
           </blockquote>
           <table datatable [dtOptions]="dtOptions" class="row-border hover"></table>
         </div>
-        <dt-instance-snippet></dt-instance-snippet>
+        <app-dt-instance-snippet></app-dt-instance-snippet>
       </div>
     </div>
   </div>
diff --git a/demo/src/app/advanced/dt-instance.component.ts b/demo/src/app/advanced/dt-instance.component.ts
@@ -3,7 +3,7 @@ import { Component, OnInit, ViewChild } from '@angular/core';
 import { DataTableDirective } from 'angular-datatables';
 
 @Component({
-  selector: 'dt-instance',
+  selector: 'app-dt-instance',
   templateUrl: 'dt-instance.component.html'
 })
 export class DtInstanceComponent implements OnInit {
diff --git a/demo/src/app/advanced/load-dt-options-with-promise-snippet.component.ts b/demo/src/app/advanced/load-dt-options-with-promise-snippet.component.ts
@@ -1,7 +1,7 @@
 import { Component } from '@angular/core';
 
 @Component({
-  selector: 'load-dt-options-with-promise-snippet',
+  selector: 'app-load-dt-options-with-promise-snippet',
   template: `
   <div id="html" class="col s12 m9 l12">
     <h4 class="header">HTML</h4>
@@ -78,5 +78,6 @@ export class LoadDtOptionsWithPromiseComponent implements OnInit {
     }
   ]
 }</code>
-</pre>`
+</pre>
+`;
 }
diff --git a/demo/src/app/advanced/load-dt-options-with-promise.component.html b/demo/src/app/advanced/load-dt-options-with-promise.component.html
@@ -26,7 +26,7 @@ <h1 class="header center-on-small-only">Load DataTables options with promise</h1
           <h4 class="header">Preview</h4>
           <table datatable [dtOptions]="dtOptions" class="row-border hover"></table>
         </div>
-        <load-dt-options-with-promise-snippet></load-dt-options-with-promise-snippet>
+        <app-load-dt-options-with-promise-snippet></app-load-dt-options-with-promise-snippet>
       </div>
     </div>
   </div>
diff --git a/demo/src/app/advanced/load-dt-options-with-promise.component.ts b/demo/src/app/advanced/load-dt-options-with-promise.component.ts
@@ -4,7 +4,7 @@ import { Http } from '@angular/http';
 import 'rxjs/add/operator/toPromise';
 
 @Component({
-  selector: 'load-dt-options-with-promise',
+  selector: 'app-load-dt-options-with-promise',
   templateUrl: 'load-dt-options-with-promise.component.html'
 })
 export class LoadDtOptionsWithPromiseComponent implements OnInit {
diff --git a/demo/src/app/advanced/row-click-event-snippet.component.ts b/demo/src/app/advanced/row-click-event-snippet.component.ts
@@ -1,7 +1,7 @@
 import { Component } from '@angular/core';
 
 @Component({
-  selector: 'row-click-event-snippet',
+  selector: 'app-row-click-event-snippet',
   template: `
   <div id="html" class="col s12 m9 l12">
     <h4 class="header">HTML</h4>
diff --git a/demo/src/app/advanced/row-click-event.component.html b/demo/src/app/advanced/row-click-event.component.html
@@ -28,7 +28,7 @@ <h4 class="header">Preview</h4>
           <br />
           <table datatable [dtOptions]="dtOptions" class="row-border hover"></table>
         </div>
-        <row-click-event-snippet></row-click-event-snippet>
+        <ap-row-click-event-snippet></app-row-click-event-snippet>
       </div>
     </div>
   </div>
diff --git a/demo/src/app/advanced/row-click-event.component.ts b/demo/src/app/advanced/row-click-event.component.ts
@@ -3,11 +3,11 @@ import { Component, NgZone, OnInit } from '@angular/core';
 declare var $: any;
 
 @Component({
-  selector: 'row-click-event',
+  selector: 'app-row-click-event',
   templateUrl: 'row-click-event.component.html'
 })
 export class RowClickEventComponent implements OnInit {
-  message: string = '';
+  message = '';
   dtOptions: any = {};
 
   constructor(private zone: NgZone) { }
@@ -30,7 +30,7 @@ export class RowClickEventComponent implements OnInit {
         data: 'lastName'
       }],
       rowCallback: (nRow: number, aData: any, iDisplayIndex: number, iDisplayIndexFull: number) => {
-        let self = this;
+        const self = this;
         // Unbind first in order to avoid any duplicate handler
         // (see https://github.com/l-lin/angular-datatables/issues/87)
         $('td', nRow).unbind('click');
diff --git a/demo/src/app/app.component.spec.ts b/demo/src/app/app.component.spec.ts
@@ -13,21 +13,21 @@ describe('AppComponent', () => {
   });
 
   it('should create the app', async(() => {
-    let fixture = TestBed.createComponent(AppComponent);
-    let app = fixture.debugElement.componentInstance;
+    const fixture = TestBed.createComponent(AppComponent);
+    const app = fixture.debugElement.componentInstance;
     expect(app).toBeTruthy();
   }));
 
   it(`should have as title 'app works!'`, async(() => {
-    let fixture = TestBed.createComponent(AppComponent);
-    let app = fixture.debugElement.componentInstance;
+    const fixture = TestBed.createComponent(AppComponent);
+    const app = fixture.debugElement.componentInstance;
     expect(app.title).toEqual('app works!');
   }));
 
   it('should render title in a h1 tag', async(() => {
-    let fixture = TestBed.createComponent(AppComponent);
+    const fixture = TestBed.createComponent(AppComponent);
     fixture.detectChanges();
-    let compiled = fixture.debugElement.nativeElement;
+    const compiled = fixture.debugElement.nativeElement;
     expect(compiled.querySelector('h1').textContent).toContain('app works!');
   }));
 });
diff --git a/demo/src/app/app.module.ts b/demo/src/app/app.module.ts
@@ -16,16 +16,16 @@ import { WelcomeComponent } from './welcome.component';
 import { GettingStartedComponent } from './getting-started.component';
 
 // Basic examples
-import { ZeroConfigComponent }  from './basic/zero-config.component';
-import { ZeroConfigSnippetComponent }  from './basic/zero-config-snippet.component';
-import { WithOptionsComponent }  from './basic/with-options.component';
-import { WithOptionsSnippetComponent }  from './basic/with-options-snippet.component';
-import { WithAjaxComponent }  from './basic/with-ajax.component';
-import { WithAjaxSnippetComponent }  from './basic/with-ajax-snippet.component';
+import { ZeroConfigComponent } from './basic/zero-config.component';
+import { ZeroConfigSnippetComponent } from './basic/zero-config-snippet.component';
+import { WithOptionsComponent } from './basic/with-options.component';
+import { WithOptionsSnippetComponent } from './basic/with-options-snippet.component';
+import { WithAjaxComponent } from './basic/with-ajax.component';
+import { WithAjaxSnippetComponent } from './basic/with-ajax-snippet.component';
 
 // Advanced examples
-import { DtInstanceComponent } from './advanced/dt-instance.component';
-import { DtInstanceSnippetComponent } from './advanced/dt-instance-snippet.component';
+import {  DtInstanceComponent } from './advanced/dt-instance.component';
+import {  DtInstanceSnippetComponent } from './advanced/dt-instance-snippet.component';
 import { LoadDtOptionsWithPromiseComponent } from './advanced/load-dt-options-with-promise.component';
 import { LoadDtOptionsWithPromiseSnippetComponent } from './advanced/load-dt-options-with-promise-snippet.component';
 import { RowClickEventComponent } from './advanced/row-click-event.component';
@@ -45,7 +45,7 @@ import { RowClickEventSnippetComponent } from './advanced/row-click-event-snippe
     WithAjaxSnippetComponent,
 
     DtInstanceComponent,
-    DtInstanceSnippetComponent,
+    DtInstanceSnippetComponent,
     LoadDtOptionsWithPromiseComponent,
     LoadDtOptionsWithPromiseSnippetComponent,
     RowClickEventComponent,
@@ -63,6 +63,6 @@ import { RowClickEventSnippetComponent } from './advanced/row-click-event-snippe
   providers: [
     HighlightJsService
   ],
-  bootstrap: [ AppComponent ]
+  bootstrap: [AppComponent]
 })
-export class AppModule {}
+export class AppModule { }
diff --git a/demo/src/app/basic/with-ajax-snippet.component.ts b/demo/src/app/basic/with-ajax-snippet.component.ts
@@ -1,7 +1,7 @@
 import { Component } from '@angular/core';
 
 @Component({
-  selector: 'with-ajax-snippet',
+  selector: 'app-with-ajax-snippet',
   template: `
   <div id="html" class="col s12 m9 l12">
     <h4 class="header">HTML</h4>
diff --git a/demo/src/app/basic/with-ajax.component.html b/demo/src/app/basic/with-ajax.component.html
@@ -26,7 +26,7 @@ <h1 class="header center-on-small-only">With ajax</h1>
           <h4 class="header">Preview</h4>
           <table datatable [dtOptions]="dtOptions" class="row-border hover"></table>
         </div>
-        <with-ajax-snippet></with-ajax-snippet>
+        <app-with-ajax-snippet></app-with-ajax-snippet>
       </div>
 
     </div>
diff --git a/demo/src/app/basic/with-ajax.component.ts b/demo/src/app/basic/with-ajax.component.ts
@@ -1,7 +1,7 @@
 import { Component, OnInit } from '@angular/core';
 
 @Component({
-  selector: 'with-ajax',
+  selector: 'app-with-ajax',
   templateUrl: 'with-ajax.component.html'
 })
 export class WithAjaxComponent implements OnInit {
diff --git a/demo/src/app/basic/with-options-snippet.component.ts b/demo/src/app/basic/with-options-snippet.component.ts
@@ -1,7 +1,7 @@
 import { Component } from '@angular/core';
 
 @Component({
-  selector: 'with-options-snippet',
+  selector: 'app-with-options-snippet',
   template: `
   <div id="html" class="col s12 m9 l12">
     <h4 class="header">HTML</h4>
diff --git a/demo/src/app/basic/with-options.component.html b/demo/src/app/basic/with-options.component.html
@@ -95,7 +95,7 @@ <h4 class="header">Preview</h4>
             </tbody>
           </table>
         </div>
-        <with-options-snippet></with-options-snippet>
+        <app-with-options-snippet></app-with-options-snippet>
       </div>
     </div>
   </div>
diff --git a/demo/src/app/basic/with-options.component.ts b/demo/src/app/basic/with-options.component.ts
@@ -1,7 +1,7 @@
 import { Component, OnInit } from '@angular/core';
 
 @Component({
-  selector: 'with-options',
+  selector: 'app-with-options',
   templateUrl: 'with-options.component.html'
 })
 export class WithOptionsComponent implements OnInit {
diff --git a/demo/src/app/basic/zero-config-snippet.component.ts b/demo/src/app/basic/zero-config-snippet.component.ts
@@ -1,7 +1,7 @@
 import { Component } from '@angular/core';
 
 @Component({
-  selector: 'zero-config-snippet',
+  selector: 'app-zero-config-snippet',
   template: `
   <div id="html" class="col s12 m9 l12">
     <h4 class="header">HTML</h4>
diff --git a/demo/src/app/basic/zero-config.component.html b/demo/src/app/basic/zero-config.component.html
@@ -95,7 +95,7 @@ <h4 class="header">Preview</h4>
             </tbody>
           </table>
         </div>
-        <zero-config-snippet></zero-config-snippet>
+        <app-zero-config-snippet></app-zero-config-snippet>
       </div>
     </div>
   </div>
diff --git a/demo/src/app/basic/zero-config.component.ts b/demo/src/app/basic/zero-config.component.ts
@@ -1,7 +1,7 @@
 import { Component } from '@angular/core';
 
 @Component({
-  selector: 'zero-config',
+  selector: 'app-zero-config',
   templateUrl: 'zero-config.component.html'
 })
 export class ZeroConfigComponent {
diff --git a/demo/src/app/getting-started.component.ts b/demo/src/app/getting-started.component.ts
@@ -1,7 +1,7 @@
 import { Component } from '@angular/core';
 
 @Component({
-  selector: 'getting-started',
+  selector: 'app-getting-started',
   templateUrl: 'getting-started.component.html'
 })
 export class GettingStartedComponent {
diff --git a/demo/src/app/welcome.component.ts b/demo/src/app/welcome.component.ts
@@ -1,7 +1,7 @@
 import { Component } from '@angular/core';
 
 @Component({
-  selector: 'welcome',
+  selector: 'app-welcome',
   templateUrl: 'welcome.component.html',
   styleUrls: ['./welcome.component.css']
 })
diff --git a/package.json b/package.json
@@ -47,6 +47,7 @@
     "@types/jasmine": "2.5.40",
     "@types/node": "~6.0.46",
     "canonical-path": "0.0.2",
+    "codelyzer": "~2.0.1",
     "concat-cli": "4.0.0",
     "concurrently": "~2.2.0",
     "http-server": "~0.9.0",
@@ -61,7 +62,7 @@
     "rollup": "~0.41.4",
     "rollup-plugin-uglify": "~1.0.1",
     "systemjs": "0.19.41",
-    "tslint": "~3.7.4",
+    "tslint": "~4.5.1",
     "typescript": "~2.0.10"
   },
   "engines": {
diff --git a/src/angular-datatables.directive.ts b/src/angular-datatables.directive.ts
@@ -5,7 +5,7 @@
  * found in the LICENSE file at https://raw.githubusercontent.com/l-lin/angular-datatables/master/LICENSE
  */
 
-import { Directive, ElementRef, Inject, OnInit, Input } from '@angular/core';
+import { Directive, ElementRef, Inject, OnInit, Input, Component } from '@angular/core';
 import 'jquery';
 import 'datatables.net';
 declare var $: any;
@@ -35,7 +35,7 @@ export class DataTableDirective implements OnInit {
   ngOnInit() {
     this.dtInstance = new Promise((resolve, reject) => {
       Promise.resolve(this.dtOptions).then(dtOptions => {
-        let dt = $(this.el.nativeElement).DataTable(dtOptions);
+        const dt = $(this.el.nativeElement).DataTable(dtOptions);
         resolve(dt);
       });
     });
diff --git a/tslint.json b/tslint.json
@@ -1,5 +1,9 @@
 {
+  "rulesDirectory": [
+    "node_modules/codelyzer"
+  ],
   "rules": {
+    "callable-types": true,
     "class-name": true,
     "comment-format": [
       true,
@@ -8,12 +12,14 @@
     "curly": true,
     "eofline": true,
     "forin": true,
+    "import-blacklist": [true, "rxjs"],
+    "import-spacing": true,
     "indent": [
       true,
       "spaces"
     ],
+    "interface-over-type-literal": true,
     "label-position": true,
-    "label-undefined": true,
     "max-line-length": [
       true,
       140
@@ -36,18 +42,17 @@
     ],
     "no-construct": true,
     "no-debugger": true,
-    "no-duplicate-key": true,
     "no-duplicate-variable": true,
     "no-empty": false,
+    "no-empty-interface": true,
     "no-eval": true,
-    "no-inferrable-types": true,
+    "no-inferrable-types": [true, "ignore-params"],
     "no-shadowed-variable": true,
     "no-string-literal": false,
+    "no-string-throw": true,
     "no-switch-case-fall-through": true,
     "no-trailing-whitespace": true,
     "no-unused-expression": true,
-    "no-unused-variable": true,
-    "no-unreachable": true,
     "no-use-before-declare": true,
     "no-var-keyword": true,
     "object-literal-sort-keys": false,
@@ -58,6 +63,7 @@
       "check-else",
       "check-whitespace"
     ],
+    "prefer-const": true,
     "quotemark": [
       true,
       "single"
@@ -80,6 +86,8 @@
         "variable-declaration": "nospace"
       }
     ],
+    "typeof-compare": true,
+    "unified-signatures": true,
     "variable-name": false,
     "whitespace": [
       true,
@@ -89,6 +97,19 @@
       "check-separator",
       "check-type"
     ],
-    "no-unused-variable": [false]
+
+    "component-selector": [true, "element", "app", "kebab-case"],
+    "use-input-property-decorator": true,
+    "use-output-property-decorator": true,
+    "use-host-property-decorator": true,
+    "no-input-rename": true,
+    "no-output-rename": true,
+    "use-life-cycle-interface": true,
+    "use-pipe-transform-interface": true,
+    "component-class-suffix": true,
+    "directive-class-suffix": true,
+    "no-access-missing-member": true,
+    "templates-use-public": true,
+    "invoke-injectable": true
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`import { Component } from '@angular/core';`
`2`	`2`
`3`	`3`	`@Component({`
`4`		`- selector: 'load-dt-options-with-promise-snippet',`
	`4`	`+ selector: 'app-load-dt-options-with-promise-snippet',`
`5`	`5`	template: `
`6`	`6`	`<div id="html" class="col s12 m9 l12">`
`7`	`7`	`<h4 class="header">HTML</h4>`
`@@ -78,5 +78,6 @@ export class LoadDtOptionsWithPromiseComponent implements OnInit {`
`78`	`78`	`}`
`79`	`79`	`]`
`80`	`80`	`}</code>`
`81`		-</pre>`
	`81`	`+</pre>`
	`82`	+`;
`82`	`83`	`}`