Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatic Approval is migrated outside of the Prow to the Cloud Run. #12439

Closed
4 tasks
Tracked by #10076
, #12438
...
Sawthis opened this issue Dec 9, 2024 · 1 comment
Closed
4 tasks
Tracked by #10076
, #12438
...

Automatic Approval is migrated outside of the Prow to the Cloud Run. #12439

Sawthis opened this issue Dec 9, 2024 · 1 comment

Comments

@Sawthis
Copy link
Contributor

Sawthis commented Dec 9, 2024 •
edited
Loading

Description

Migrate Automatic Approval outside of the Prow. Currently, Automatic Approval is a Prow plugin.

Reasons

Removal of Prow.

Acceptance Criteria

  • It must accept events from the event arc.
  • Automatic Approval is migrated outside of the Prow to the Cloud Run.
  • Get all secrets from the GCP Secret Manager dynamically.
  • Update the documentation for the Automatic Approval.

Attachments

#11627
@Sawthis Sawthis mentioned this issue Dec 9, 2024
Closed
4 tasks
@Sawthis Sawthis mentioned this issue Jan 30, 2025
Closed
17 tasks
@Sawthis
Copy link
Contributor Author

Sawthis commented Feb 21, 2025

We should use a ready-on-the-market solution for it: #12709

@Sawthis Sawthis closed this as not planned Won't fix, can't repro, duplicate, stale Feb 21, 2025
@Sawthis Sawthis mentioned this issue Mar 13, 2025
Open
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Sawthis