chore: refactor test resource applier #2731
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
kind/chore
NHingerl
previously approved these changes
Dec 2, 2025
NHingerl
approved these changes
Dec 2, 2025
shorim
reviewed
Dec 4, 2025
| testutils "github.com/kyma-project/telemetry-manager/internal/utils/test" | ||
| "github.com/kyma-project/telemetry-manager/test/testkit/assert" | ||
| kitk8s "github.com/kyma-project/telemetry-manager/test/testkit/k8s" | ||
| "github.com/kyma-project/telemetry-manager/test/testkit/k8s/objects" |
Contributor
There was a problem hiding this comment.
Suggested change
| "github.com/kyma-project/telemetry-manager/test/testkit/k8s/objects" | |
| kitk8sobjects "github.com/kyma-project/telemetry-manager/test/testkit/k8s/objects" |
let's use the alias here the same way you did it in the actual tests
shorim
reviewed
Dec 5, 2025
| name types.NamespacedName, | ||
| resourceName string, | ||
| ) { | ||
| type ReadinessCheckFunc func(t *testing.T, name types.NamespacedName) (bool, error) |
Contributor
There was a problem hiding this comment.
Do we need to export this type?
shorim
reviewed
Dec 5, 2025
| return nil | ||
| } | ||
|
|
||
| func AllObjectsDeleted(resources ...client.Object) error { |
Contributor
There was a problem hiding this comment.
Do we need to export this function?
shorim
reviewed
Dec 5, 2025
| return nil | ||
| } | ||
|
|
||
| func DeleteObjectsIgnoringNotFound(resources ...client.Object) error { |
Contributor
There was a problem hiding this comment.
Do we need to export this function?
shorim
reviewed
Dec 5, 2025
| return labelMatches(labels, kitk8sobjects.PersistentLabelName, "true") | ||
| } | ||
|
|
||
| func ResetTelemetryResource(t *testing.T, previous operatorv1alpha1.Telemetry) { |
Contributor
There was a problem hiding this comment.
Do we need to export this function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request (what was done and why):
Changes refer to particular issues, PRs or documents:
Traceability
Related Issuessection.