Skip to content

Commit 07c44f8

Browse files
authored
Unifying release assets names (#209)
1 parent d0a2433 commit 07c44f8

File tree

11 files changed

+26
-24
lines changed

11 files changed

+26
-24
lines changed

.gitignore

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@ module-chart-test
3333
mod
3434
charts
3535
default.yaml
36-
template.yaml
37-
template-k3d.yaml
36+
moduletemplate.yaml
37+
moduletemplate-k3d.yaml
3838
docs/.DS_Store
3939
.DS_Store
4040
__debug_bin
@@ -43,4 +43,4 @@ vendor
4343
serverless-operator.yaml
4444
manifests/serverless/rendered.yaml
4545
serverless.yaml
46-
template-latest.yaml
46+
moduletemplate-latest.yaml

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,10 +128,10 @@ module-image: docker-build docker-push ## Build the Module Image and push it to
128128
.PHONY: module-build
129129
module-build: kyma kustomize ## Build the Module and push it to a registry defined in MODULE_REGISTRY.
130130
cd config/operator && $(KUSTOMIZE) edit set image controller=${IMG}
131-
@$(KYMA) alpha create module --default-cr=config/samples/operator_v1alpha1_serverless.yaml \
131+
@$(KYMA) alpha create module --default-cr=config/samples/default_serverless_cr.yaml \
132132
--channel=${MODULE_CHANNEL} --name kyma.project.io/module/$(MODULE_NAME) \
133133
--version $(MODULE_VERSION) --path . $(MODULE_CREATION_FLAGS) \
134-
--output=template.yaml
134+
--output=moduletemplate.yaml
135135

136136
##@ Build Dependencies
137137

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ kubectl apply -f https://github.com/kyma-project/serverless-manager/releases/lat
1818
To get Serverless installed, apply the sample Serverless CR:
1919

2020
```bash
21-
kubectl apply -f config/samples/operator_v1alpha1_serverless.yaml
21+
kubectl apply -f https://github.com/kyma-project/serverless-manager/releases/latest/download/default_serverless_cr.yaml
2222
```
2323

2424
## Development
@@ -87,13 +87,13 @@ kubectl apply -f config/samples/operator_v1alpha1_serverless.yaml
8787
- Create a Serverless instance.
8888

8989
```bash
90-
kubectl apply -f config/samples/operator_v1alpha1_serverless.yaml
90+
kubectl apply -f config/samples/default_serverless_cr.yaml
9191
```
9292

9393
- Delete a Serverless instance.
9494

9595
```bash
96-
kubectl delete -f config/samples/operator_v1alpha1_serverless.yaml
96+
kubectl delete -f config/samples/default_serverless_cr.yaml
9797
```
9898

9999
- Use external registry.

config/ui-extensions/serverless/general

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,5 @@ features:
1111
disableCreate: true
1212
disableDelete: true
1313
description: >-
14-
{{[Serverless CR](https://github.com/kyma-project/serverless-manager/blob/main/config/samples/operator_v1alpha1_serverless.yaml)}}
14+
{{[Serverless CR](https://github.com/kyma-project/serverless-manager/blob/main/config/samples/default_serverless_cr.yaml)}}
1515
specifies serverless module.

docs/contributor/manual-installation-on-k3d.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
4141
> **NOTE:** The following sub-steps are temporary workarounds.
4242
43-
Edit `template.yaml` under the `config/moduletemplates` folder and:
43+
Edit `moduletemplate.yaml` under the `config/moduletemplates` folder and:
4444
4545
- change `target` to `control-plane`
4646
@@ -69,7 +69,7 @@
6969
Use the `--template` flag to deploy the Serverless module manifest from the beginning, or apply it using kubectl later.
7070
7171
```bash
72-
kyma alpha deploy --templates=./config/moduletemplates/template.yaml
72+
kyma alpha deploy --templates=./config/moduletemplates/moduletemplate.yaml
7373
```
7474
7575
Kyma installation is ready, but the module is not yet activated.

hack/ci/Makefile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ module-build: ## Build the Module, push it to a registry and print it based on t
2525
MODULE_VERSION=${MODULE_VERSION}-${MODULE_SHA}
2626

2727
@echo "\n~~~~~~~~~~~~BEGINING OF MODULE TEMPLATE~~~~~~~~~~~~~~"
28-
@cat ${PROJECT_ROOT}/template.yaml
28+
@cat ${PROJECT_ROOT}/moduletemplate.yaml
2929
@echo "\n~~~~~~~~~~~~~~~END OF MODULE TEMPLATE~~~~~~~~~~~~~~~~"
3030

3131
##@ Tests
@@ -68,8 +68,8 @@ remove-serverless: ## Remove Serverless CR
6868
.PHONY: install-latest-serverless
6969
install-latest-serverless:
7070
@make -C ${PROJECT_COMMON} kyma create-k3d
71-
curl -LJ -s https://github.com/kyma-project/serverless-manager/releases/latest/download/moduletemplate.yaml > ${PROJECT_ROOT}/template-latest.yaml
72-
@cat ${PROJECT_ROOT}/template-latest.yaml | sed -e 's/enableInternal: true/enableInternal: false/g' > ${PROJECT_ROOT}/template-k3d.yaml
71+
curl -LJ -s https://github.com/kyma-project/serverless-manager/releases/latest/download/moduletemplate.yaml > ${PROJECT_ROOT}/moduletemplate-latest.yaml
72+
@cat ${PROJECT_ROOT}/moduletemplate-latest.yaml | sed -e 's/enableInternal: true/enableInternal: false/g' > ${PROJECT_ROOT}/moduletemplate-k3d.yaml
7373
@make -C ${PROJECT_COMMON} install-kyma-with-lm patch-mod-mgr-role install-module-template enable-module verify-kyma
7474

7575
.PHONY: reinstall-serverless

hack/common/Makefile

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ OPERATOR_IMAGE_NAME ?= serverless-operator-dev-local
1313
OPERATOR_IMAGE_TAG ?= $(MODULE_VERSION)
1414

1515

16-
TEMPLATE_PATH ?= ${PROJECT_ROOT}/template.yaml
16+
TEMPLATE_PATH ?= ${PROJECT_ROOT}/moduletemplate.yaml
1717

1818
KYMA ?= ${PROJECT_ROOT}/bin/kyma-unstable
1919

@@ -91,21 +91,21 @@ install-kyma-with-lm:
9191

9292
.PHONY: install-module-template
9393
install-module-template: ## Apply k3d-ready moduletemplate.
94-
kubectl apply -f ${PROJECT_ROOT}/template-k3d.yaml
94+
kubectl apply -f ${PROJECT_ROOT}/moduletemplate-k3d.yaml
9595

9696

9797
.PHONY: fix-template
98-
fix-template: ## Create template-k3d.yaml based on template.yaml with right URLs.
99-
@cat ${PROJECT_ROOT}/template.yaml \
98+
fix-template: ## Create moduletemplate-k3d.yaml based on moduletemplate.yaml with right URLs.
99+
@cat ${PROJECT_ROOT}/moduletemplate.yaml \
100100
| sed -e 's/remote/control-plane/g' \
101101
-e 's/${REGISTRY_PORT}/5000/g' \
102102
-e 's/localhost/k3d-${REGISTRY_NAME}.localhost/g' \
103-
> ${PROJECT_ROOT}/template-k3d.yaml
103+
> ${PROJECT_ROOT}/moduletemplate-k3d.yaml
104104

105105
.PHONY: apply-serverless
106106
apply-serverless: ## Apply the k3d serverless CR.
107107
kubectl apply -n kyma-system \
108-
-f ${PROJECT_ROOT}/config/samples/operator_v1alpha1_serverless.yaml
108+
-f ${PROJECT_ROOT}/config/samples/default_serverless_cr.yaml
109109

110110
### Internal Dependencies
111111

0 commit comments

Comments
 (0)