Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add labels to nodes which indicate the worker pool owner + HA support enabled #706

Open
7 tasks
tobiscr opened this issue Mar 3, 2025 · 5 comments
Open
7 tasks
Labels
area/control-plane Related to all activities around Kyma Control Plane kind/feature Categorizes issue or PR as related to a new feature.

Comments

@tobiscr
Copy link
Contributor

tobiscr commented Mar 3, 2025

Description

To make the worker pool feature more transparent and flexible, we are going to add more metadata (as labels) to worker pools. These label have to be added to all nodes.

Indicator for worker-pool owner:
To distinguish the Kyma owned worker pool (name: cpu-worker-0) from customer worker pools, a dedicated label has to be added which indicates whether the worker pool is owned by the customer or by Kyma.

Proposal: worker.kyma.io/pool-owner: [customer|kyma]

Indicator whether worker-pool is running in HA mode:
It should be possible to see if a node belongs to a worker-pool which runs in HA mode. HA is indicated by using 3 different zones for the worker pool.

Proposal: worker.kyma.io/pool-ha-enabled: true/false

AC:

  • Define the labels name and value and share it within the team and document it in this issue.
  • Adjust KIM to set the labels-field in the Shoot spec:
    • Label indicating whether the worker-pool runs in HA mode
    • Label indiacting the worker-pool owner
  • Implement an unit-test which confirms the existence of these labels within the Shoot-Spec.

Reasons

Introduce labels to provide metadata related to worker pools. These labels can be used for assigning workloads to the Kyma worker pool, respectively to distinguish the Kyma worker pool from customer worker pools. But also to see if a worker-pool is configured to run in HA mode.

Attachments

@tobiscr tobiscr added area/control-plane Related to all activities around Kyma Control Plane kind/feature Categorizes issue or PR as related to a new feature. labels Mar 3, 2025
@tobiscr tobiscr changed the title Set a dedicated label on nodes which belong to Kyma's default worker pool Set a label on nodes to indicate the worker pool owner Mar 3, 2025
@tobiscr tobiscr changed the title Set a label on nodes to indicate the worker pool owner Set a label on nodes to indicate the worker pool owner + HA support available Mar 5, 2025
@tobiscr tobiscr changed the title Set a label on nodes to indicate the worker pool owner + HA support available Set a label on nodes to indicate the worker pool owner + HA support enabled Mar 5, 2025
@tobiscr
Copy link
Contributor Author

tobiscr commented Mar 5, 2025

Required by kyma-project/busola#3621

@tobiscr tobiscr changed the title Set a label on nodes to indicate the worker pool owner + HA support enabled Add labels to nodes which indicate the worker pool owner + HA support enabled Mar 5, 2025
@mrCherry97
Copy link

hi @tobiscr
could we also with this issue add information about the min/max to the labels, or somewhere where Kyma Dashboard can take this data and display in the node details?
MIN-value = amount of used zones in a worker pool (a worker-pool has to have 1 VM per zone), MAX-value=TBC if we can show it - not available in SKR at the moment

@tobiscr
Copy link
Contributor Author

tobiscr commented Mar 6, 2025

Yes, from technical side, it's possible to add the autoscaler-configuration as additional label (e.g. as example, we could add one label for min-value worker.kyma.io/pool-autoscaler-min: 3 and an additional label including the max-value worker.kyma.io/pool-autoscaler-max: 20).

What I see a bit critical is the growing number of labels.

But maybe it's worth to expose parts of the Runtime-Configuration in general on SKRs in a CRD. @akgalwas - what do you think about this idea (e.g. we also have a need to expose the public-IP to customers, this would require one more label etc.)?

@mrCherry97
Copy link

okay, so please also add it, and we will adjust these informations in node details as follow-up. thanks!

@tobiscr
Copy link
Contributor Author

tobiscr commented Mar 10, 2025

Relates to #618

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/control-plane Related to all activities around Kyma Control Plane kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants