Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add COLRv1 palette querying, switching, and custom setting hooks #259

Open
HinTak opened this issue Aug 19, 2024 · 3 comments
Open

Add COLRv1 palette querying, switching, and custom setting hooks #259

HinTak opened this issue Aug 19, 2024 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@HinTak
Copy link
Collaborator

HinTak commented Aug 19, 2024

See https://typedrawers.com/discussion/5105/is-anyone-actually-using-color-fonts and
https://github.com/kyamagu/skia-python/blob/main/patch/skia-m123-colrv1-freetype.diff , especially the "palette" argument/area.

@HinTak HinTak added enhancement New feature or request good first issue Good for newcomers labels Aug 19, 2024
@HinTak
Copy link
Collaborator Author

HinTak commented Aug 19, 2024

This is mostly a reminder for myself and/or good first issue for new external contribution.

@HinTak
Copy link
Collaborator Author

HinTak commented Aug 19, 2024

Just to be explicit - it is still my suggestion to remove the COLRv1 patch (and the other stub in font.cpp) if I disappear/unresponsive for any lengthy period.

@HinTak
Copy link
Collaborator Author

HinTak commented Nov 13, 2024

I had a small update to the colrv1 patch to expose the font descriptor in m129 which was only posted in my skia-building-fun repo (now included here in the m132 update), but it looks like upstream in m132 provides a different way of accessing the palettes via #282 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant