This repository has been archived by the owner on Aug 10, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 57
Housekeeping on client connections #2
Comments
Per @swishy, Wasabi doesn't yet have a callback for a websocket connection closing, but he is going to add it. |
See wasabifx/wasabi#108, thanks Ian. |
Note that we also need a mechanism to allow resources to be cleaned up when a client connection is terminated. This could be a callback specified within the KWeb() {
// ... build page here
onDisconnect() {
// Cleanup resources here
}
} Here we've added a |
This was fixed in commit bb43a39 (sorry about the crappy commit message). |
sanity
added a commit
that referenced
this issue
Oct 9, 2022
sanity
added a commit
that referenced
this issue
Oct 18, 2022
tokuhirom
pushed a commit
to tokuhirom/kweb-core
that referenced
this issue
Oct 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Information on WebSocket connection to clients is kept in KWeb.clients, currently a ConcurrentHashMap.
This means that they won't be deleted until the server is restarted. We should keep track of when clients disconnect from the server and delete any associated data.
The text was updated successfully, but these errors were encountered: