Skip to content

Commit 6c4fa5e

Browse files
committed
Merge pull request #36 from kuzzleio/bugfix
bugfix
2 parents b222adc + f6fe863 commit 6c4fa5e

File tree

5 files changed

+15
-4
lines changed

5 files changed

+15
-4
lines changed

dist/kuzzle.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1273,7 +1273,7 @@ KuzzleDataCollection.prototype.createDocument = function (id, document, options,
12731273
data = {},
12741274
action = 'create';
12751275

1276-
if (typeof id !== 'string' && id !== null) {
1276+
if (id && typeof id !== 'string') {
12771277
cb = options;
12781278
options = document;
12791279
document = id;

dist/kuzzle.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/kuzzle.min.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/kuzzleDataCollection.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ KuzzleDataCollection.prototype.createDocument = function (id, document, options,
174174
data = {},
175175
action = 'create';
176176

177-
if (typeof id !== 'string' && id !== null) {
177+
if (id && typeof id !== 'string') {
178178
cb = options;
179179
options = document;
180180
document = id;

test/kuzzleDataCollection/methods.test.js

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -289,6 +289,17 @@ describe('KuzzleDataCollection methods', function () {
289289
collection.createDocument(null, {}, {}, function () {});
290290
should(emitted).be.true();
291291

292+
collection.createDocument(undefined, {});
293+
should(emitted).be.true();
294+
295+
emitted = false;
296+
collection.createDocument(undefined, {}, function () {});
297+
should(emitted).be.true();
298+
299+
emitted = false;
300+
collection.createDocument(undefined, {}, {}, function () {});
301+
should(emitted).be.true();
302+
292303
emitted = false;
293304
collection.createDocument({}, function () {});
294305
should(emitted).be.true();

0 commit comments

Comments
 (0)