Move EventStore.Plugins.Connectors to main repo. #4960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed whitespace added roslynator analysers refactored activation a bit
not building yet
builds again but still broken
…ams when a connector is created or deleted
…ation command tests
…nfigured (#67) Co-authored-by: YoEight <[email protected]> Co-authored-by: William Chong <[email protected]>
Co-authored-by: William Chong <[email protected]> Co-authored-by: YoEight <[email protected]>
Co-authored-by: Sérgio Silveira <[email protected]>
…leases and checkpoints Refactored stream configuration and deletion logic by introducing `DeleteConnectorStreams` delegate to extend previous functionality. Updated service registrations, command handling, and supervisor logic.
… op when not set Introduced new utility methods for configuration conversions and refactored the data protection logic to enforce stricter token validations. Updated tests to align with changes, added support for handling sensitive keys dynamically, and improved protection and unprotection workflows. This also includes adjustments to ensure compatibility with Http Sink Connectors and improved test coverage for various scenarios.
… key identifier Adjusted the keyIdentifier in ConnectorDataProtector to fix incorrect key usage during value protection. Added IDataProtector as a dependency to ConnectorsStreamSupervisor to properly manage data protection functionalities. Updated ManagementPlaneWireUp to register IDataProtector for DI and refactored some unused methods for clarity. Included a comment addressing a known issue to be resolved in a future cleanup task.
Default Surge key vault `ProtobufEncoding` to `false`.
# Conflicts: # src/EventStore.Extensions.Connectors/Planes/Management/ManagementPlaneWireUp.cs
Previously, deactivation relied directly on the `DeactivateConnector` logic which did not provide a clear mechanism to wait for connector stoppage. The new `WaitForDeactivation` method in `ConnectorsActivator` ensures connectors are properly waited upon until they are fully deactivated, improving reliability and control during shutdown processes.
Qodana for .NET392 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
YoEight
force-pushed
the
yoeight/integ-connectors
branch
from
e6b05d4 to
62422de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.