Skip to content

Move all commercial plugins to the main repo. #4820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 47 commits into
base: master
Choose a base branch
from

Conversation

YoEight
Copy link
Member

@YoEight YoEight commented Feb 10, 2025

No description provided.

Copy link
Contributor

github-actions bot commented Feb 10, 2025

Qodana for .NET

543 new problems were found

Inspection name Severity Problems
Reference to a volatile field will not be treated as volatile 🔴 Failure 1
The switch expression does not handle all possible inputs (it is not exhaustive). 🔴 Failure 1
Dereference of a possibly null reference. 🔴 Failure 1
Redundant using directive 🔶 Warning 266
Namespace does not correspond to file location 🔶 Warning 99
Redundant name qualifier 🔶 Warning 28
Unused parameter (private accessibility) 🔶 Warning 25
Type member is never used (private accessibility) 🔶 Warning 18
Parameter is only used for precondition check (private accessibility) 🔶 Warning 13
Unused local variable 🔶 Warning 9
Possible 'System.NullReferenceException' 🔶 Warning 7
Redundant cast 🔶 Warning 6
Auto-property accessor is never used (private accessibility) 🔶 Warning 6
Invalid XML documentation comment 🔶 Warning 5
'??' condition is never null according to nullable reference types' annotations 🔶 Warning 5
Private field can be converted into local variable 🔶 Warning 5
Redundant anonymous type property explicit name 🔶 Warning 5
Conditional access qualifier expression is known to be null or not null 🔶 Warning 3
Non-accessed field (private accessibility) 🔶 Warning 3
Possible multiple enumeration 🔶 Warning 3
Redundant argument with default value 🔶 Warning 3
Possible 'null' assignment to non-nullable entity 🔶 Warning 2
Use null check pattern instead of a type check succeeding on any not-null value 🔶 Warning 2
Assignment is not used 🔶 Warning 2
Redundant nullable warning suppression expression 🔶 Warning 2
Do not use object initializer for 'using' variable 🔶 Warning 2
Virtual member call in constructor 🔶 Warning 2
Access to a static member of a type via a derived type 🔶 Warning 1
Collection content is never queried (private accessibility) 🔶 Warning 1
Expression is always 'true' or 'false' according to nullable reference types' annotations 🔶 Warning 1
'??' condition is known to be null or not null 🔶 Warning 1
Empty constructor 🔶 Warning 1
Empty namespace declaration 🔶 Warning 1
Member hides static member from outer class 🔶 Warning 1
Member initialized value ignored 🔶 Warning 1
Non-accessed positional property (private accessibility) 🔶 Warning 1
Non-accessed local variable 🔶 Warning 1
Return value must be disposed but the method or function is not annotated with [MustDisposeResource] 🔶 Warning 1
Redundant 'partial' modifier on type declaration 🔶 Warning 1
Redundant base constructor call 🔶 Warning 1
Redundant member initializer 🔶 Warning 1
Redundant class or interface specification in base types list 🔶 Warning 1
Return type of a function can be non-nullable 🔶 Warning 1
Method return value is never used (private accessibility) 🔶 Warning 1
Type is never used (private accessibility) 🔶 Warning 1
Unused type parameter 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@YoEight YoEight marked this pull request as ready for review February 12, 2025 23:07
@YoEight YoEight requested a review from a team as a code owner February 12, 2025 23:07
@YoEight
Copy link
Member Author

YoEight commented Feb 21, 2025

LDAPS tests have been disabled when running on Windows while OAuth tests have been disabled completely because they need a rewrite.

Copy link

cloudflare-workers-and-pages bot commented Feb 26, 2025

Deploying eventstore with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7e677a6
Status: ✅  Deploy successful!
Preview URL: https://26ff2f02.eventstore.pages.dev
Branch Preview URL: https://yoeight-plugins-revamp.eventstore.pages.dev

View logs

YoEight and others added 4 commits February 26, 2025 17:38
* feat: solution filter for connectors plugin

* feat: use surge via project reference

* chore: remove submodules and reference surge via package

* chore: remove connectors plugin solution file

* fixup

* chore: upgrade surge packages to latest

* chore: rebrand connectors plugin tests

* feat: solution filter for connectors plugin

* chore: remove deps that are no longer needed

* fixup

* chore: remove unused methods from processor builder and options
Copy link
Contributor

@timothycoleman timothycoleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

juuuust registering my interest in approving this :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants