-
Notifications
You must be signed in to change notification settings - Fork 658
[KDB-506] read load attribution spike #4649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
timothycoleman
wants to merge
38
commits into
release/oss-v23.10
Choose a base branch
from
timothycoleman/readload-attribution-spike
base: release/oss-v23.10
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[KDB-506] read load attribution spike #4649
timothycoleman
wants to merge
38
commits into
release/oss-v23.10
from
timothycoleman/readload-attribution-spike
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ind it on the workitem instead (so that it can vary depending on the user) (not actually setting it in the workitem yet)
a188b4e
to
54ee607
Compare
…o store the tracker in the reader but it makes more sense to do this in the lease
…ll end up in the OS page cache and not the Disk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We capture metrics of #events and #bytes read - this spike breaks these metrics down by user and source (file / chunk cache) to make it easier to see which applications are causing load, and especially disk load.
We also now capture reads for replication