[gnhf#195] fix(agents): recover wrapped Pi JSON output

[github-actions]

Decision needed - gnhf#195

PR review by jasonqlwilliams-alt · merge-ready

fix(agents): recover wrapped Pi JSON output

Situation

• Compliance: pass
• Tests: green
• Configured checks: PR must be raised via no-mistakes (compliance: pass), Generated files must not be hand-edited (informational: pass), build-and-test (macos-latest) (test: pass), build-and-test (ubuntu-latest) (test: pass), build-and-test (windows-latest) (test: pass)
• Freshness: complete target observation as of 2026-08-10T21:08:43Z
• Notes: compliance=pass tests=green

Related work

Note

Related-work context is truncated (comparison_incomplete): comparison across open pull requests is incomplete, so a relation may be missed; this says nothing about the target itself. The candidate list, shared paths, and references are advisory display only and never an overlap or action gate.

• kunchenguid/gnhf#164 - fix(agents): recover pi JSON output that follows prose - exact shared paths: src/core/agents/copilot.ts, src/core/agents/json-extract.ts, src/core/agents/opencode.ts
• kunchenguid/gnhf#179 - feat(agents): wait for the usage window to reset instead of aborting on rate limits - exact shared path: src/core/agents/types.ts

Advisory context only. Shared paths and references are not an auto-merge overlap gate.

Auto-merge criteria

Note

Read-only preflight from the authoritative auto-merge evaluator. A displayed MET result never authorizes a merge: Wheelhouse re-evaluates every gate and performs G7 immediately before acting.

Scope

• ✅ MET Scope - merge-ready PR review - kind=pr-review bucket=merge-ready

Safety

• ✅ MET Safety - complete healthy scan - repo scan is ok, complete, and mergeability settled
• ✅ MET Safety - target PR is open - target PR is open and unmerged
• ✅ MET Safety - no per-PR auto-merge opt-out - wheelhouse:no-auto-merge is absent
• ✅ MET Safety - head SHA unchanged - scan and live head c68a596f

G0 (repo)

• ✅ MET G0 - repository auto-merge enabled - enabled by effective repository policy
• ⚪ UNAVAILABLE G0 - default-branch VISION.md present - VISION.md missing or unreadable on the default branch

G1 (card)

• ✅ MET G1 - trusted unique decision card - trusted unique machine-created card [gnhf#195] fix(agents): recover wrapped Pi JSON output #2369
• ✅ MET G1 - card published after triage - decision controls are published
• ⚪ UNAVAILABLE G1 - exclusive card claim - claim is acquired and revalidated only at the act boundary

G2 (files)

• ✅ MET G2 - complete immutable file list - 7 immutable changed path entries read
• ✅ MET G2 - workflow and security exclusions clear - no unconditional workflow/security/governance exclusions

G3 (author)

• ✅ MET G3 - non-maintainer human contributor - jasonqlwilliams-alt is a non-maintainer human
• ✅ MET G3 - prior merged contribution in this repo - jasonqlwilliams-alt has at least one prior merged PR in gnhf

G4 (checks)

• ✅ MET G4 - configured checks green - comp=pass tests=green (merge-ready)
• ✅ MET G4 - PR mergeable - live mergeable is MERGEABLE
• ✅ MET G4 - merge state clean - live merge state is CLEAN

G5 (size)

• ✅ MET G5 - changed-file limit - 7 changed files <= 20
• ✅ MET G5 - changed-line limit - 190 changed lines <= 1000

G6 (triage + behavior)

• ✅ MET G6 - automatic triage credential configured - model credential is configured; card triage eligibility is evaluated separately
• ✅ MET G6 - successful triage for current head - successful triage for head c68a596f
• ✅ MET G6 - top-level recommendation is merge - explicit merge recommendation
• ✅ MET G6 - eligible behavior class - class B with bounded corrected-defect and restored-behavior evidence
• ✅ MET G6 - existing/default behavior unchanged - no existing/default behavior change
• ✅ MET G6 - class C is opt-in and default-off - not applicable to class B
• VISION.md-dependent checks - needs VISION.md
  • ⚪ UNAVAILABLE G6 - behavior aligns with VISION.md - not evaluated because a trusted default-branch VISION.md is required
  • ⚪ UNAVAILABLE G6 - behavior verdict recommends merge - not evaluated because a trusted default-branch VISION.md is required
  • ⚪ UNAVAILABLE G6 - verdict uses current VISION.md revision - not evaluated because a trusted default-branch VISION.md is required
  • ⚪ UNAVAILABLE G6 - verdict uses current base revision - not evaluated because a trusted default-branch VISION.md is required

G7 (final gate)

• ⚪ UNAVAILABLE G7 - immediate live recheck and manual merge gate - runs only immediately before merge: card claim, VISION, head/base, mergeability, checks, opt-out label, and unchanged manual workflow gate

Triage

• Summary: Routes the Pi adapter through the shared JSON-recovery path to fix silent failures on prose-prefixed or Markdown-fenced output, and consolidates identical Copilot/OpenCode local recovery functions into the same shared helper.
• Product implications: Routine fix: Pi users whose responses arrived with prose preambles or Markdown fences were silently failing with a parse error; this restores recovery parity with rovodev and ACP adapters without touching their code paths.

Recommended action

• Agent recommendation: merge
• Reason: Clean class-B fix: Pi JSON-parse defect corrected and reproduced against the base build, two regression tests added, Copilot/OpenCode consolidation is a pure refactor with logically identical logic, and all five CI checks including Windows are green.

From the current admitted automatic triage assessment for this exact revision. Tick Accept recommendation to apply it - it is advisory and never an auto-merge authorization.

Your decision

Tick one box for a quick call, or reply with a slash-command (/merge, /close, /decline <reason>, /hold, /comment <text>, /request-changes <text>):

• Accept recommendation
• Merge it
• Close / decline
• Investigate - deep code-grounded review (leaves this card open)
• Hold - I'll handle this manually

_{Only the repository owner can drive this decision - everyone else's edits and comments are ignored.}

[github-actions]

Agent triage event finished with consumer.committed.

[github-actions]

Triage result projected.

[github-actions]

[github-actions]

Merged gnhf#195 (squash).