Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(kind): remove unused variable and rename file #9339

Merged
merged 7 commits into from
Feb 22, 2024

Conversation

lukidzi
Copy link
Contributor

@lukidzi lukidzi commented Feb 21, 2024

Checklist prior to review

Config files always have suffix based onKIND_CLUSTER_NAME.

@lukidzi lukidzi requested a review from a team as a code owner February 21, 2024 16:13
@lukidzi lukidzi requested review from slonka, jakubdyszkiewicz and lobkovilya and removed request for a team February 21, 2024 16:13
Copy link
Contributor

@michaelbeaumont michaelbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC the previous attempt broke CI #9026

Signed-off-by: Lukasz Dziedziak <[email protected]>
@michaelbeaumont
Copy link
Contributor

Also originally the problem comes from #8676

@lukidzi lukidzi added the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Feb 21, 2024
@lukidzi
Copy link
Contributor Author

lukidzi commented Feb 21, 2024

I see, the previous pr was adding -1 to each file configuration name. I think now I've renamed the file correctly + using the value provided in KIND_CLUSTER_NAME so I hope it should work. I am going to run full matrix.

Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds solid to me!

@slonka slonka merged commit 4edee4f into kumahq:master Feb 22, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make kind/start fails with "No kind clusters found." (because cluster-kuma.yaml doesn't exist)
4 participants