-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(kind): remove unused variable and rename file #9339
Conversation
Signed-off-by: Lukasz Dziedziak <[email protected]>
Signed-off-by: Lukasz Dziedziak <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC the previous attempt broke CI #9026
Signed-off-by: Lukasz Dziedziak <[email protected]>
Also originally the problem comes from #8676 |
I see, the previous pr was adding |
Signed-off-by: Lukasz Dziedziak <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds solid to me!
Checklist prior to review
Config files always have suffix based on
KIND_CLUSTER_NAME
.make kind/start
fails with "No kind clusters found." (because cluster-kuma.yaml doesn't exist) #9131syscall.Mkfifo
have equivalent implementation on the other OS --ci/
labels to run additional/fewer testsUPGRADE.md
? --