Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(meshmetric): meshmetric profiles MADR #9269

Merged
merged 21 commits into from
Mar 4, 2024

Conversation

slonka
Copy link
Contributor

@slonka slonka commented Feb 15, 2024

Don't have any other ideas, maybe someone reads this before weekend and can chip in some ideas.

closes: #8845

Also I can remove the files i added in assets/038/ - I used them to get the data for combined.txt - these are metrics combined from all dashboards available - and compare that to what's default in Envoy and in DD metadata list.

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@slonka slonka added the ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change) label Feb 15, 2024
@slonka slonka marked this pull request as ready for review February 16, 2024 13:46
@slonka slonka requested a review from a team as a code owner February 16, 2024 13:46
@slonka slonka requested review from jakubdyszkiewicz, Automaat, lobkovilya, johnharris85 and a team and removed request for a team February 16, 2024 13:46
@slonka slonka marked this pull request as draft February 21, 2024 13:31
@slonka
Copy link
Contributor Author

slonka commented Feb 21, 2024

Moving this back to draft until I make the adjustments.

@slonka slonka marked this pull request as ready for review February 23, 2024 08:33
@slonka slonka requested a review from johnharris85 February 23, 2024 12:20
@slonka slonka requested a review from Automaat February 23, 2024 12:20
@slonka slonka requested a review from lahabana February 26, 2024 15:36
Signed-off-by: Krzysztof Słonka <[email protected]>
@slonka slonka requested review from lahabana and a team March 1, 2024 08:35
Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments around syntax and implem but looking good!

docs/madr/decisions/038-meshmetric-profiles.md Outdated Show resolved Hide resolved
docs/madr/decisions/038-meshmetric-profiles.md Outdated Show resolved Hide resolved
docs/madr/decisions/038-meshmetric-profiles.md Outdated Show resolved Hide resolved
docs/madr/decisions/038-meshmetric-profiles.md Outdated Show resolved Hide resolved
docs/madr/decisions/038-meshmetric-profiles.md Outdated Show resolved Hide resolved
@slonka slonka merged commit 2a95b49 into kumahq:master Mar 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement metrics profiles in MeshMetric policy
5 participants