Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does ConfigMapReconciler need to watch Dataplanes? #8749

Open
lobkovilya opened this issue Jan 4, 2024 · 5 comments
Open

Does ConfigMapReconciler need to watch Dataplanes? #8749

lobkovilya opened this issue Jan 4, 2024 · 5 comments
Labels
kind/docs About docs triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@lobkovilya
Copy link
Contributor

What happened?

ConfigMapReconciler watches Dataplane resource

kuma/pkg/plugins/runtime/k8s/controllers/configmap_controller.go

Line 90 in beb3c36

Watches(&mesh_k8s.Dataplane{}, kube_handler.EnqueueRequestsFromMapFunc(DataplaneToMeshMapper(r.Log, r.SystemNamespace, r.ResourceConverter))).

But it's probably unnecessary since DPP inbounds can't be changed without a k8s service change and ConfigMapReconciler already watches services.
@lobkovilya lobkovilya added triage/pending This issue will be looked at on the next triage meeting kind/improvement Improvement on an existing feature labels Jan 4, 2024
@jakubdyszkiewicz jakubdyszkiewicz added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Jan 8, 2024
@jakubdyszkiewicz
Copy link
Contributor

Triage: to solve this, we need to add a comment why we need to listen on Dataplane. It's because we can add labels (converted to tags) in runtime that are then picked by VirtualOutbounds.

@jakubdyszkiewicz jakubdyszkiewicz added kind/docs About docs and removed kind/improvement Improvement on an existing feature labels Jan 8, 2024
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Apr 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 8, 2024

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lukidzi lukidzi removed the triage/stale Inactive for some time. It will be triaged again label Apr 8, 2024
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Jul 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2024

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@jakubdyszkiewicz jakubdyszkiewicz removed the triage/stale Inactive for some time. It will be triaged again label Jul 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Oct 9, 2024
@lukidzi lukidzi removed the triage/stale Inactive for some time. It will be triaged again label Oct 21, 2024
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Jan 21, 2025
@github-actions GitHub Actions
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lukidzi lukidzi removed the triage/stale Inactive for some time. It will be triaged again label Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/docs About docs triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jakubdyszkiewicz @lobkovilya @lukidzi