-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Potential to trigger ConfigMapReconciler less on MeshGateway changes #8748
Comments
|
Yeah I don't think we need MeshGatewayRoute, information from them isn't used in the VIP handling |
This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. |
This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. |
This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. |
This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed. |
What happened?
Kuma CP enqueues events for all MeshGateways even though we can do this only for MeshGateways with crossMesh listeners
kuma/pkg/plugins/runtime/k8s/controllers/configmap_controller.go
Line 157 in beb3c36
By looking at the algorithm that generates VIPs it seems like we don't need to watch MeshGatewayRoutes
kuma/pkg/plugins/runtime/k8s/controllers/configmap_controller.go
Line 95 in beb3c36
The text was updated successfully, but these errors were encountered: