Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential to trigger ConfigMapReconciler less on MeshGateway changes #8748

Open
lobkovilya opened this issue Jan 4, 2024 · 6 comments
Open
Labels
kind/improvement Improvement on an existing feature triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@lobkovilya
Copy link
Contributor

What happened?

  1. Kuma CP enqueues events for all MeshGateways even though we can do this only for MeshGateways with crossMesh listeners

    func MeshGatewayToMeshMapper(client kube_client.Reader, l logr.Logger, ns string, resourceConverter k8s_common.Converter) kube_handler.MapFunc {

  2. By looking at the algorithm that generates VIPs it seems like we don't need to watch MeshGatewayRoutes

    Watches(&mesh_k8s.MeshGatewayRoute{}, kube_handler.EnqueueRequestsFromMapFunc(MeshGatewayRouteToMeshMapper(mgr.GetClient(), r.Log, r.SystemNamespace, r.ResourceConverter))).

@lobkovilya lobkovilya added triage/pending This issue will be looked at on the next triage meeting kind/bug A bug kind/improvement Improvement on an existing feature and removed kind/bug A bug labels Jan 4, 2024
@jakubdyszkiewicz jakubdyszkiewicz added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Jan 8, 2024
@jakubdyszkiewicz
Copy link
Contributor

Triage: @michaelbeaumont to check if need this

@jakubdyszkiewicz jakubdyszkiewicz added triage/needs-information Reviewed and some extra information was asked to the reporter and removed triage/accepted The issue was reviewed and is complete enough to start working on it labels Jan 8, 2024
@michaelbeaumont
Copy link
Contributor

Yeah I don't think we need MeshGatewayRoute, information from them isn't used in the VIP handling

@michaelbeaumont michaelbeaumont added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/needs-information Reviewed and some extra information was asked to the reporter labels Jan 8, 2024
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Apr 8, 2024
Copy link
Contributor

github-actions bot commented Apr 8, 2024

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lukidzi lukidzi removed the triage/stale Inactive for some time. It will be triaged again label Apr 8, 2024
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Jul 8, 2024
Copy link
Contributor

github-actions bot commented Jul 8, 2024

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@jakubdyszkiewicz jakubdyszkiewicz removed the triage/stale Inactive for some time. It will be triaged again label Jul 10, 2024
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Oct 9, 2024
Copy link
Contributor

github-actions bot commented Oct 9, 2024

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lukidzi lukidzi removed the triage/stale Inactive for some time. It will be triaged again label Oct 21, 2024
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Jan 21, 2025
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lukidzi lukidzi removed the triage/stale Inactive for some time. It will be triaged again label Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/improvement Improvement on an existing feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Development

No branches or pull requests

4 participants