Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh interval should be a configuration on the zone object in global not a CP config #7143

Closed
lahabana opened this issue Jun 29, 2023 · 6 comments
Labels
kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@lahabana
Copy link
Contributor

Description

It makes more sense for global to control the frequency of refreshes as an admin might want to increase this for everyone quickly.

My guess is this could be a config in the zone resource (like enabled) and we'd have a good default in the global CP config.
Does this also apply to backoff?

The backward compat seems straight forward. KDS sends this in metadata, if we receive it we ignore the local config.

@lahabana lahabana added triage/pending This issue will be looked at on the next triage meeting kind/feature New feature labels Jun 29, 2023
@jakubdyszkiewicz
Copy link
Contributor

Triage: we need to protect against the excessive KDS DiscoveryRequest anyways. How would both values interact with each other?

@jakubdyszkiewicz jakubdyszkiewicz added triage/needs-information Reviewed and some extra information was asked to the reporter and removed triage/pending This issue will be looked at on the next triage meeting labels Jul 3, 2023
@lahabana
Copy link
Contributor Author

lahabana commented Jul 4, 2023

I think if both are set the global control takes over (which makes an easy backward compat path too). In the long term I think the zone cp param should be removed

@lahabana lahabana added triage/pending This issue will be looked at on the next triage meeting and removed triage/needs-information Reviewed and some extra information was asked to the reporter labels Jul 4, 2023
@michaelbeaumont michaelbeaumont added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Jul 10, 2023
@michaelbeaumont
Copy link
Contributor

Triage: global needs control over zone CP refresh interval
Migration: both CPs can set it, global takes priority -> remove option from zone CP
Can we rate limit DiscoveryRequests from global?

@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Oct 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@slonka slonka removed the triage/stale Inactive for some time. It will be triaged again label Oct 9, 2023
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Jan 8, 2024
Copy link
Contributor

github-actions bot commented Jan 8, 2024

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@jakubdyszkiewicz jakubdyszkiewicz removed the triage/stale Inactive for some time. It will be triaged again label Jan 8, 2024
@jakubdyszkiewicz
Copy link
Contributor

Triage: we now have a backoff mechanism
# This is a way to slow down Zone CP from sending resources too often.
responseBackoff: 0s # ENV: KUMA_MULTIZONE_GLOBAL_KDS_RESPONSE_BACKOFF

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Development

No branches or pull requests

4 participants