Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kuma should allow to define empty list of reachableServices #5041

Closed
lukidzi opened this issue Sep 21, 2022 · 11 comments
Closed

Kuma should allow to define empty list of reachableServices #5041

lukidzi opened this issue Sep 21, 2022 · 11 comments
Labels
area/policies good first issue Good for newcomers kind/bug A bug triage/pending This issue will be looked at on the next triage meeting

Comments

@lukidzi
Copy link
Contributor

lukidzi commented Sep 21, 2022

What happened?

Sometimes services don't need to communicate with other services and in this case, they might not require changes/observer all services in the infrastructure. Currently, it is not possible to define an empty list of reachable services.
On Kubernetes you can define kuma.io/transparent-proxying-reachable-services: "[]" and in this case, it won't match with any outbound. But, Kuma sees this as a list of service with the name[]. We should define maybe some value/annotation that will allow disabling tracking of all services.

@lukidzi lukidzi added triage/pending This issue will be looked at on the next triage meeting kind/bug A bug labels Sep 21, 2022
@jakubdyszkiewicz
Copy link
Contributor

A workaround is to put random non-existent service like this:

kuma.io/transparent-proxying-reachable-services: "non-existing-service"

It's because in protobuf [] = nil

@jakubdyszkiewicz jakubdyszkiewicz added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Sep 26, 2022
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Jan 25, 2023
@github-actions
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lukidzi lukidzi removed the triage/stale Inactive for some time. It will be triaged again label Jan 30, 2023
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label May 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2023

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@slonka slonka removed the triage/stale Inactive for some time. It will be triaged again label May 2, 2023
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Aug 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@bartsmykla bartsmykla removed the triage/stale Inactive for some time. It will be triaged again label Aug 8, 2023
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Nov 8, 2023
Copy link
Contributor

github-actions bot commented Nov 8, 2023

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@jakubdyszkiewicz jakubdyszkiewicz removed the triage/stale Inactive for some time. It will be triaged again label Nov 9, 2023
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Feb 8, 2024
Copy link
Contributor

github-actions bot commented Feb 8, 2024

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@slonka slonka removed the triage/stale Inactive for some time. It will be triaged again label Feb 9, 2024
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label May 10, 2024
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@bartsmykla bartsmykla added good first issue Good for newcomers and removed triage/stale Inactive for some time. It will be triaged again labels May 14, 2024
@lahabana
Copy link
Contributor

Is this any better with MeshService? Is it also possible to have label based reachable services for example to have an entire namespace?

@jakubdyszkiewicz
Copy link
Contributor

Yes, you can use label to select a namespace. We still treat empty reachable-backend-refs as "reach all" I think. I just pinged @lukidzi to make sure we fix it for the new annotation

@lahabana
Copy link
Contributor

@lukidzi can you confirm we can to no service? Also we discussed a mode for MeshService which would require using ReachableServices have we got an issue to track this?

@lahabana lahabana removed the triage/accepted The issue was reviewed and is complete enough to start working on it label Sep 19, 2024
@lahabana lahabana added the triage/pending This issue will be looked at on the next triage meeting label Sep 19, 2024
@jakubdyszkiewicz
Copy link
Contributor

for reachable backends we can do this: {}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/policies good first issue Good for newcomers kind/bug A bug triage/pending This issue will be looked at on the next triage meeting
Projects
None yet
Development

No branches or pull requests

5 participants