MeshTimeout defaults in Kuma 2.9.x

[lobkovilya]

Root cause in 2.9.0

The initial bug was introduced in 2.9.0 with #11060 by creating an incorrect DefaultTimeoutConf structure:

var DefaultTimeoutConf = api.Conf{
	ConnectionTimeout: &kube_meta.Duration{Duration: policies_defaults.DefaultConnectTimeout},
	IdleTimeout:       &kube_meta.Duration{Duration: policies_defaults.DefaultIdleTimeout},
	Http: &api.Http{
		RequestTimeout:        &kube_meta.Duration{Duration: policies_defaults.DefaultRequestTimeout},
		// Incorrect value
		StreamIdleTimeout:     &kube_meta.Duration{Duration: policies_defaults.DefaultGatewayStreamIdleTimeout},
		MaxStreamDuration:     &kube_meta.Duration{Duration: policies_defaults.DefaultMaxStreamDuration},
		// Incorrect value
		MaxConnectionDuration: &kube_meta.Duration{Duration: policies_defaults.DefaultConnectTimeout},
		RequestHeadersTimeout: &kube_meta.Duration{Duration: policies_defaults.DefaultRequestHeadersTimeout},
	},
}

As a result of the initial bug in Kuma 2.9.0 we have:

• StreamIdleTimeout is 5 sec instead of 30 min
• MaxConnectionDuration is 5 sec instead of 0 (disabled)

Incorrect fix in 2.9.1

Users noticed that bug during the upgrade to Kuma 2.9.0 and we got the issue #12033.

The issue was fixed incorrectly #12043, instead of fixing the broken DefaultTimeoutConf structure we added continue:

if conf == nil {
-   conf = &plugin_xds.DefaultTimeoutConf
+   continue
}

As a result of the incorrect fix in Kuma 2.9.1 we have:

• connectTimeout is 10 sec instead of 5 sec
• idleTimeout is 2h instead of 1h
• requestTimeout is 0 (disabled) instead of 15 sec