Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(watchdog): wait for the first tick #12693

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(watchdog): wait for the first tick #12693

wants to merge 2 commits into from

Conversation

lukidzi
Copy link
Contributor

@lukidzi lukidzi commented Jan 28, 2025 •
edited
Loading

Motivation

Issue: #12657

While investigating the issue, I noticed that the channel is closed after the first OnTick call, not after the first clock Tick. I am not sure if this behavior was intentional, as I couldn't find any documentation about it (#11590). However, based on the test description, it seems the expectation aligns with WaitForFirstTick.

Implementation information

I changed the order to close channel after first tick, also added Eventually since we run goroutines and we cannot guarantee the order execution.

Also, changed Consistently(hasTicked).ShouldNot(Receive()) to

Consistently(func(g Gomega) {
    g.Expect(hasTicked).ShouldNot(Receive())
}, "100ms", "10ms").Should(Succeed())

since the first one check it only once

fix: #12657

@lukidzi lukidzi requested a review from lahabana January 28, 2025 14:04
@lukidzi lukidzi requested a review from a team as a code owner January 28, 2025 14:04
@lukidzi lukidzi requested a review from lobkovilya January 28, 2025 14:04
@github-actions GitHub Actions
Copy link
Contributor

Reviewer Checklist

🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
If something doesn't apply please check the box and add a justification if the reason is non obvious.

  • Is the PR title satisfactory? Is this part of a larger feature and should be grouped using > Changelog?
  • PR description is clear and complete. It Links to relevant issue as well as docs and UI issues
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as an image registry)
  • IPv6 is taken into account (.e.g: no string concatenation of host port)
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • Don't forget ci/ labels to run additional/fewer tests
  • Does this contain a change that needs to be notified to users? In this case, UPGRADE.md should be updated.
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label)

@lukidzi
review
0bab99e 
Signed-off-by: Lukasz Dziedziak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lobkovilya lobkovilya lobkovilya left review comments

@lahabana lahabana Awaiting requested review from lahabana

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flake SimpleWatchdog [It] should wait for the first tick to happen on WaitForFirstTick
2 participants
@lukidzi @lobkovilya