Replace legacy facts - make puppet8 ready

Author: yorickps

manifests/init.pp

@@ -8,8 +8,6 @@
   String $config_class  = $opensm::params::config_class,
   String $service       = $opensm::params::service
 ) inherits opensm::params {
-
-
   class { 'opensm::install':
     enabled  => $enabled,
     packages => $packages,
@@ -29,14 +27,14 @@
     }
 
     anchor { 'opensm::begin': ; }
-      -> Class['opensm::install']
-      -> Class["opensm::config::${config_class}"]
-      ~> Class['opensm::service']
-      -> anchor { 'opensm::end': ; }
+    -> Class['opensm::install']
+    -> Class["opensm::config::${config_class}"]
+    ~> Class['opensm::service']
+    -> anchor { 'opensm::end': ; }
   } else {
     anchor { 'opensm::begin': ; }
-      -> Class['opensm::service']
-      -> Class['opensm::install']
-      -> anchor { 'opensm::end': ; }
+    -> Class['opensm::service']
+    -> Class['opensm::install']
+    -> anchor { 'opensm::end': ; }
   }
 }

manifests/params.pp

@@ -4,23 +4,23 @@
   $priority = 0
   $options = {}
 
-  case $::operatingsystem {
-    debian,ubuntu: {
+  case $facts['os']['name'] {
+    'Debian','Ubuntu': {
       $guids = 'ALL'
       $service = 'opensm'
       $configuration = '/etc/opensm/opensm.conf'
       $config_class = 'debian'
     }
 
-    redhat,centos,scientific,oraclelinux,fedora,rocky,almalinux: {
+    'RedHat','Centos','Scientific','OracleLinux','Fedora','Rocky','AlmaLinux': {
       $guids = ''
       $service = 'opensm'
       $configuration = '/etc/rdma/opensm.conf'
       $config_class = 'redhat'
     }
 
     default: {
-      fail("Unsupported OS: ${::operatingsystem}")
+      fail("Unsupported OS: ${facts['os']['name']}")
     }
   }
 }