From 6b2ae5142f1d745a81736b258b5f4f95fa43aff1 Mon Sep 17 00:00:00 2001 From: Patrick Ohly Date: Wed, 24 Sep 2025 19:56:25 +0200 Subject: [PATCH] SIG testing: use only label filter for alpha/beta jobs The implicit default for SKIP is '\[Serial\]'. That's surprising ("what you see is *not* what you get") and unnecessary for these jobs. If we have serial tests, then we can and should run them to get full coverage. There is a risk that too many serial tests slow down the overall job. If that is the case, then skipping serial tests should be added back inside the label filter. FOCUS doesn't have a default in these jobs, but elsewhere it defaults to '[Conformance]'. It's safer to explicitly set it - perhaps someone does a copy-and-paste of these settings. --- .../sig-testing/kubernetes-kind-presubmits.yaml | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/config/jobs/kubernetes/sig-testing/kubernetes-kind-presubmits.yaml b/config/jobs/kubernetes/sig-testing/kubernetes-kind-presubmits.yaml index e0014fb0275f..1ed70b0c4b09 100644 --- a/config/jobs/kubernetes/sig-testing/kubernetes-kind-presubmits.yaml +++ b/config/jobs/kubernetes/sig-testing/kubernetes-kind-presubmits.yaml @@ -299,6 +299,10 @@ presubmits: value: '{"AllBeta":true}' - name: RUNTIME_CONFIG value: '{"api/beta":"true", "api/ga":"true"}' + - name: SKIP + value: "" + - name: FOCUS + value: "" - name: LABEL_FILTER value: "Feature: isSubsetOf OffByDefault && !Alpha && !Deprecated && !Slow && !Disruptive && !Flaky" - name: PARALLEL @@ -346,6 +350,10 @@ presubmits: value: '{"AllAlpha":true,"AllBeta":true,"EventedPLEG":false}' - name: RUNTIME_CONFIG value: '{"api/all":"true"}' + - name: SKIP + value: "" + - name: FOCUS + value: "" - name: LABEL_FILTER value: "Feature: isSubsetOf OffByDefault && !Deprecated && !Slow && !Disruptive && !Flaky" - name: PARALLEL @@ -392,6 +400,10 @@ presubmits: value: '{"AllAlpha":true,"AllBeta":true,"EventedPLEG":false}' - name: RUNTIME_CONFIG value: '{"api/all":"true"}' + - name: SKIP + value: "" + - name: FOCUS + value: "" - name: LABEL_FILTER value: "Feature: isSubsetOf OffByDefault && !Deprecated && !Slow && !Disruptive && !Flaky" - name: PARALLEL