fix: Minimize logging when waiting for IP address

Author: henry3260

pkg/drivers/common/common.go

@@ -206,8 +206,6 @@ func getIPAddressFromFile(mac, path string) (string, error) {
 	if err != nil {
 		return "", err
 	}
-
-	log.Debugf("Searching for %s in %s ...", mac, path)
 	file, err := os.Open(path)
 	if err != nil {
 		return "", err

pkg/drivers/krunkit/krunkit.go

@@ -61,6 +61,7 @@ const (
 	serialFileName = "serial.log"
 	logLevelInfo   = "3"
 	defaultSSHUser = "docker"
+	maxAttempts    = 60
 )
 
 // Driver is the machine driver for krunkit.
@@ -286,13 +287,13 @@ func (d *Driver) setupIP(mac string) error {
 		return nil
 	}
 	// Implement a retry loop because IP address isn't added to dhcp leases file immediately
-	for i := 0; i < 60; i++ {
-		log.Debugf("Attempt %d", i)
+	for i := 0; i < maxAttempts; i++ {
 		err = getIP()
 		if err == nil {
 			break
 		}
 		time.Sleep(2 * time.Second)
+		log.Debugf("Searching for %s in %s (attempt %d/%d)", d.MACAddress, common.LeasesPath, i+1, maxAttempts)
 	}
 
 	if err == nil {

pkg/drivers/qemu/qemu.go

@@ -56,8 +56,8 @@ const (
 	isoFilename        = "boot2docker.iso"
 	serialFileName     = "serial.log"
 	privateNetworkName = "docker-machines"
-
-	defaultSSHUser = "docker"
+	defaultSSHUser     = "docker"
+	maxAttempts        = 60
 )
 
 type Driver struct {
@@ -521,13 +521,13 @@ func (d *Driver) Start() error {
 		if detect.NestedVM() {
 			multiplier = 3 // will help with running in Free github action Macos VMs (takes 112+ retries on average)
 		}
-		for i := 0; i < 60*multiplier; i++ {
-			log.Debugf("Attempt %d", i)
+		for i := 0; i < maxAttempts*multiplier; i++ {
 			err = getIP()
 			if err == nil {
 				break
 			}
 			time.Sleep(2 * time.Second)
+			log.Debugf("Searching for %s in %s (attempt %d/%d)", d.MACAddress, common.LeasesPath, i+1, maxAttempts*multiplier)
 		}
 
 		if err == nil {

pkg/drivers/vfkit/vfkit.go

@@ -62,6 +62,7 @@ const (
 	logFileName    = "vfkit.log"
 	serialFileName = "serial.log"
 	defaultSSHUser = "docker"
+	maxAttempts    = 60
 )
 
 // Driver is the machine driver for vfkit (Virtualization.framework)
@@ -361,13 +362,13 @@ func (d *Driver) setupIP(mac string) error {
 	if detect.NestedVM() {
 		multiplier = 3 // will help with running in Free github action Macos VMs (takes 160+ retries on average)
 	}
-	for i := 0; i < 60*multiplier; i++ {
-		log.Debugf("Attempt %d", i)
+	for i := 0; i < maxAttempts*multiplier; i++ {
 		err = getIP()
 		if err == nil {
 			break
 		}
 		time.Sleep(2 * time.Second)
+		log.Debugf("Searching for %s in %s (attempt %d/%d)", d.MACAddress, common.LeasesPath, i+1, maxAttempts*multiplier)
 	}
 
 	if err == nil {