-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We should notify the user to pass the GOROOT env when invoking the client-gen #178
Comments
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close not-planned |
@k8s-triage-robot: Closing this issue, marking it as "Not Planned". In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
We have noticed the client-gen failed to run sometimes in GitHub Action. After the investigation in mosn/htnn#687, we found that the GOROOT mismatching causes it.
The client-gen imports gengo, and gengo imports
go/build
. Thego/build
module will invoke the go toolchain to generate the go code. If theGOROOT
is not given as the env var,go/build
will use the builtin default GOROOT to look up the go toolchain.This brings a problem when the client-gen is built with a go compiler A and then executed on a machine that has a go compiler B, the builtin GOROOT is different from the real GOROOT, causes
fork/exec xxx/go: no such file or directory
error.To avoid such an error, we should notify the user to pass the GOROOT env when invoking the client-gen, so the environment to build client-gen doesn't impact the environment to use client-gen. For example,
GOROOT=$(go env GOROOT) client-gen ...
.The text was updated successfully, but these errors were encountered: