drop Requeue entirely

Signed-off-by: sivchari <[email protected]>

Author: sivchari

internal/util/controller/controller_test.go

@@ -185,7 +185,6 @@ func TestReconcileMetrics(t *testing.T) {
 		res, err = r.Reconcile(t.Context(), req)
 		g.Expect(err).To(HaveOccurred())
 		g.Expect(res.RequeueAfter).To(Equal(time.Duration(0)))
-		g.Expect(res.Requeue).To(BeFalse()) //nolint:staticcheck // We have to handle Requeue until it is removed
 		g.Expect(counterMetricValue(reconcileTotal.WithLabelValues(r.name, labelError))).To(Equal(1))
 		g.Expect(counterMetricValue(reconcileTotal.WithLabelValues(r.name, labelRequeueAfter))).To(Equal(0))
 		g.Expect(counterMetricValue(reconcileTotal.WithLabelValues(r.name, labelRequeue))).To(Equal(0))
@@ -199,26 +198,11 @@ func TestReconcileMetrics(t *testing.T) {
 		res, err = r.Reconcile(t.Context(), req)
 		g.Expect(err).ToNot(HaveOccurred())
 		g.Expect(res.RequeueAfter).To(Equal(5 * time.Second))
-		g.Expect(res.Requeue).To(BeFalse()) //nolint:staticcheck // We have to handle Requeue until it is removed
 		g.Expect(counterMetricValue(reconcileTotal.WithLabelValues(r.name, labelError))).To(Equal(1))
 		g.Expect(counterMetricValue(reconcileTotal.WithLabelValues(r.name, labelRequeueAfter))).To(Equal(1))
 		g.Expect(counterMetricValue(reconcileTotal.WithLabelValues(r.name, labelRequeue))).To(Equal(0))
 		g.Expect(counterMetricValue(reconcileTotal.WithLabelValues(r.name, labelSuccess))).To(Equal(1))
 		g.Expect(histogramMetricValue(reconcileTime.WithLabelValues(r.name))).To(Equal(3))
-
-		// Requeue
-		r.reconciler = reconcile.Func(func(_ context.Context, _ reconcile.Request) (reconcile.Result, error) {
-			return reconcile.Result{Requeue: true}, nil
-		})
-		res, err = r.Reconcile(t.Context(), req)
-		g.Expect(err).ToNot(HaveOccurred())
-		g.Expect(res.RequeueAfter).To(Equal(time.Duration(0)))
-		g.Expect(res.Requeue).To(BeTrue()) //nolint:staticcheck // We have to handle Requeue until it is removed
-		g.Expect(counterMetricValue(reconcileTotal.WithLabelValues(r.name, labelError))).To(Equal(1))
-		g.Expect(counterMetricValue(reconcileTotal.WithLabelValues(r.name, labelRequeueAfter))).To(Equal(1))
-		g.Expect(counterMetricValue(reconcileTotal.WithLabelValues(r.name, labelRequeue))).To(Equal(1))
-		g.Expect(counterMetricValue(reconcileTotal.WithLabelValues(r.name, labelSuccess))).To(Equal(1))
-		g.Expect(histogramMetricValue(reconcileTime.WithLabelValues(r.name))).To(Equal(4))
 	})
 }