simplify: cache in-cluster URL at construction, trim docstring, extract test helper

Author: vgunapati

clients/python/agentic-sandbox-client/k8s_agent_sandbox/connector.py

@@ -54,11 +54,7 @@ def verify_connection(self):
         pass
 
     def should_inject_router_headers(self) -> bool:
-        """Returns True if X-Sandbox-* router headers should be attached to requests.
-
-        Defaults to True. InClusterConnectionStrategy overrides to False because
-        requests go directly to the sandbox pod, which does not use those headers.
-        """
+        """Returns True if X-Sandbox-* router headers should be injected into requests."""
         return True
 
 class DirectConnectionStrategy(ConnectionStrategy):
@@ -190,15 +186,13 @@ def __init__(
         namespace: str,
         config: SandboxInClusterConnectionConfig,
     ):
-        self.sandbox_id = sandbox_id
-        self.namespace = namespace
-        self.config = config
+        self._base_url = (
+            f"http://{sandbox_id}.{namespace}"
+            f".svc.cluster.local:{config.server_port}"
+        )
 
     def connect(self) -> str:
-        return (
-            f"http://{self.sandbox_id}.{self.namespace}"
-            f".svc.cluster.local:{self.config.server_port}"
-        )
+        return self._base_url
 
     def verify_connection(self):
         pass

clients/python/agentic-sandbox-client/k8s_agent_sandbox/test/unit/test_sandboxclient.py

@@ -516,41 +516,26 @@ def test_in_cluster_config_default_port(self, _):
         sc = SandboxClient(connection_config=config)
         self.assertEqual(sc.connection_config.server_port, 8888)
 
-    @patch('uuid.uuid4')
-    @patch('k8s_agent_sandbox.sandbox_client.K8sHelper')
-    def test_sandbox_created_with_in_cluster_config(self, MockK8sHelper, mock_uuid):
-        mock_uuid.return_value.hex = 'aabbccdd'
-        in_cluster_config = SandboxInClusterConnectionConfig()
-        client = SandboxClient(connection_config=in_cluster_config)
-        client.k8s_helper.resolve_sandbox_name.return_value = 'my-sandbox'
-
-        mock_sandbox_class = MagicMock()
-        mock_sandbox_class.return_value = MagicMock()
-        client.sandbox_class = mock_sandbox_class
-
-        with patch.object(client, '_create_claim'), \
-             patch.object(client, '_wait_for_sandbox_ready'):
-            client.create_sandbox('my-template')
-
-        call_kwargs = mock_sandbox_class.call_args.kwargs
+    def _create_sandbox_with_in_cluster_config(self, namespace='default'):
+        with patch('k8s_agent_sandbox.sandbox_client.K8sHelper'), \
+             patch('uuid.uuid4') as mock_uuid:
+            mock_uuid.return_value.hex = 'aabbccdd'
+            client = SandboxClient(connection_config=SandboxInClusterConnectionConfig())
+            client.k8s_helper.resolve_sandbox_name.return_value = 'my-sandbox'
+            mock_sandbox_class = MagicMock()
+            mock_sandbox_class.return_value = MagicMock()
+            client.sandbox_class = mock_sandbox_class
+            with patch.object(client, '_create_claim'), \
+                 patch.object(client, '_wait_for_sandbox_ready'):
+                client.create_sandbox('my-template', namespace=namespace)
+            return mock_sandbox_class.call_args.kwargs
+
+    def test_sandbox_created_with_in_cluster_config(self):
+        call_kwargs = self._create_sandbox_with_in_cluster_config()
         self.assertIsInstance(call_kwargs['connection_config'], SandboxInClusterConnectionConfig)
 
-    @patch('uuid.uuid4')
-    @patch('k8s_agent_sandbox.sandbox_client.K8sHelper')
-    def test_sandbox_namespace_passed_correctly(self, MockK8sHelper, mock_uuid):
-        mock_uuid.return_value.hex = 'aabbccdd'
-        client = SandboxClient(connection_config=SandboxInClusterConnectionConfig())
-        client.k8s_helper.resolve_sandbox_name.return_value = 'my-sandbox'
-
-        mock_sandbox_class = MagicMock()
-        mock_sandbox_class.return_value = MagicMock()
-        client.sandbox_class = mock_sandbox_class
-
-        with patch.object(client, '_create_claim'), \
-             patch.object(client, '_wait_for_sandbox_ready'):
-            client.create_sandbox('my-template', namespace='prod')
-
-        call_kwargs = mock_sandbox_class.call_args.kwargs
+    def test_sandbox_namespace_passed_correctly(self):
+        call_kwargs = self._create_sandbox_with_in_cluster_config(namespace='prod')
         self.assertEqual(call_kwargs['namespace'], 'prod')