Skip to content

update for vmware-exporter and component-deploy.sh#140

Merged
toschneck merged 5 commits intokubermatic:masterfrom
steled:steled-patch-1
Apr 15, 2025
Merged

update for vmware-exporter and component-deploy.sh#140
toschneck merged 5 commits intokubermatic:masterfrom
steled:steled-patch-1

Conversation

@steled
Copy link
Copy Markdown
Contributor

@steled steled commented Mar 12, 2025

What this PR does / why we need it:

  • this PR updates the following files/components
    • file: component-deploy.sh
    • component: vmware-exporter
      • file: cm.grafana-dashboard-definitions.yaml
  • this PR updates the usage of the file component-deploy.sh (it removes VALUE_FILE_OVERRIDE variable and CLI argument)
  • it also updates the vmware-exporter dashboards to fit with new Grafana version (removes Angular deprecation warning)

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

- script `component-deploy.sh` is executed via `component-deploy.sh path/to/VALUES_FILES path/to/CHART_FOLDER ($DEPLOY_S3_SYNCER|$DEPLOY_SGW|$DEPLOY_RCLONE_S3_SYNCER|$DEPLOY_THANOS_SEED_INGRESS|$DEPLOY_VMWARE_EXPORTER)`

steled added 2 commits March 12, 2025 14:41
@steled
Update component-deploy.sh
2b8981e 
- update to fit updated needs
- cleanup
  - removed non available component "cert-update-svc"
  - removed "VALUE_FILE_OVERRIDE" variable and cli argument

Signed-off-by: Stephan <34886888+steled@users.noreply.github.com>
@steled
Update cm.grafana-dashboard-definitions.yaml
122bfb9 
- updated dashboards to fit new Grafana version (removed Angular deprecation warning)

Signed-off-by: Stephan <34886888+steled@users.noreply.github.com>
@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 12, 2025
@kubermatic-bot
Copy link
Copy Markdown

kubermatic-bot commented Mar 12, 2025

Hi @steled. Thanks for your PR.

I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubermatic-bot kubermatic-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 12, 2025
@toschneck toschneck self-assigned this Mar 18, 2025
@toschneck toschneck self-requested a review March 18, 2025 15:59
@toschneck
Copy link
Copy Markdown
Member

toschneck commented Mar 18, 2025

@steled thanks for PR.
In gernal it looks good to me. As other usage may need to manage multiple values files, I would like to keep the option overwerite values of a default values files. This is helpfull for some environments.

steled added 3 commits March 19, 2025 06:51
@steled
Update component-deploy.sh
9d2e781 
update for VALUE_FILE_OVERRIDE

Signed-off-by: Stephan <34886888+steled@users.noreply.github.com>
@steled
Update component-deploy.sh
44ee575 
readd missing usage hint

Signed-off-by: Stephan <34886888+steled@users.noreply.github.com>
@steled
Update component-deploy.sh
eff61bd 
readd missing helm upgrade parameter

Signed-off-by: Stephan <34886888+steled@users.noreply.github.com>
@steled
Copy link
Copy Markdown
Contributor Author

steled commented Mar 19, 2025

@toschneck got your point. I update the check for the VALUE_FILE_OVERRIDE variable because otherwise it didn't worked if the argument $2 is empty.

@toschneck
Copy link
Copy Markdown
Member

toschneck commented Apr 15, 2025

/approve

@toschneck
Copy link
Copy Markdown
Member

toschneck commented Apr 15, 2025

/lgtm

@kubermatic-bot
Copy link
Copy Markdown

kubermatic-bot commented Apr 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: toschneck

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Apr 15, 2025
@kubermatic-bot
Copy link
Copy Markdown

kubermatic-bot commented Apr 15, 2025

LGTM label has been added.

DetailsGit tree hash: e4323d67300439e37d8e1bd6a6c3d744b65309fd

@toschneck toschneck merged commit 36016ba into kubermatic:master Apr 15, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@toschneck toschneck Awaiting requested review from toschneck

Assignees

@toschneck toschneck

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@steled @kubermatic-bot @toschneck