Skip to content

Conversation

@fresende
Copy link
Contributor

@fresende fresende commented Jul 9, 2025

Description of your changes:
Added a new page that documents how to integrate Spark Operator and Notebooks

Screenshot 2025-07-08 at 11 18 32 PM

@google-oss-prow
Copy link

Hi @fresende. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

github-actions bot commented Jul 9, 2025

🚫 This command cannot be processed. Only organization members or owners can use the commands.

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@fresende fresende changed the title [WIP] Documentation to integrate Spark Operator and Notebooks spark-operator: Documentation to integrate Spark Operator and Notebooks Jul 10, 2025
@fresende fresende force-pushed the doucmentation-spark branch from 7c38936 to 6495ba1 Compare July 10, 2025 21:21
@lresende
Copy link
Member

@fresende please sign your latest commits to fix the DCO CI issues.

After installing Kubeflow's latest manifests and following the steps described above, the changes look good to me. I only encountered the issue mentioned in jupyter-server/enterprise_gateway#1405. While we wait for the new helm with the additional configuration, you should update your patch command with the suggested environment variable from the issue.

cc @Shekharrajak

- Launch a notebook from the Kubeflow UI
- Select the `pyspark` kernel
- Write and run PySpark code
- Your notebook submits Spark jobs via JEG → Spark Operator → Kubernetes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add debugging using spark UI as well ?

Copy link
Member

@Shekharrajak Shekharrajak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this and later we can update any point.

fresende added 4 commits July 16, 2025 23:39
Signed-off-by: Fellipe Resende <[email protected]>
Signed-off-by: Fellipe Resende <[email protected]>
Signed-off-by: Fellipe Resende <[email protected]>
@fresende fresende force-pushed the doucmentation-spark branch from 65b3d95 to c4740c1 Compare July 17, 2025 06:39
@google-oss-prow google-oss-prow bot removed the lgtm label Jul 17, 2025
Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this great content @fresende!
/assign @ChenYi015 @jacobsalway @vara-bonthu @yuchaoran2011 @ImpSy @nabuskey
Please can you check it ?

fresende added 2 commits July 18, 2025 15:40
Signed-off-by: Fellipe Resende <[email protected]>
Signed-off-by: Fellipe Resende <[email protected]>
Copy link

@yuchaoran2011 yuchaoran2011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Left a minor comment. Thanks for the contribution

Signed-off-by: Fellipe Resende <[email protected]>
@ChenYi015
Copy link
Member

/approve

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this awesome contribution @fresende!
/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, ChenYi015

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 3027fc3 into kubeflow:master Jul 21, 2025
7 checks passed
image: elyra/kernel-image-puller:3.2.3
imagePullPolicy: Always
pullPolicy: Always
defaultContainerRegistry: quay.io
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're currently setting the JUPYTER_GATEWAY_URL to the service address, which allows us to avoid enabling ingress. What is your current use case that requires ingress? @Shekharrajak

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still thinking if this service will be available to call in another namespace:

kubectl -n enterprise-gateway get svc enterprise-gateway -o yaml

type: NodePort

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants