Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the remaining Kustomize 5 warnings #2991

Open
juliusvonkohout opened this issue Feb 13, 2025 · 18 comments · Fixed by #2992
Open

Fix the remaining Kustomize 5 warnings #2991

juliusvonkohout opened this issue Feb 13, 2025 · 18 comments · Fixed by #2992
Assignees
@milinddethe15
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Milestone
1.10.1

Comments

@juliusvonkohout
Copy link
Member

juliusvonkohout commented Feb 13, 2025 •
edited
Loading

You can just start creating PRs. For the common components usually within kubeflow/manifests (there i can merge them fast for you so best start there) and for most things under "apps" in the specific working group repositories, e.g. kubeflow/pipelines. We then synchronize them back with the scripts in /hack.

And of course multiple contributors can work on this task in parallel and create PRs.

Version

master

Detailed Description

kustomize build example
# Warning: 'commonLabels' is deprecated. Please use 'labels' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'commonLabels' is deprecated. Please use 'labels' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'commonLabels' is deprecated. Please use 'labels' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'vars' is deprecated. Please use 'replacements' instead. [EXPERIMENTAL] Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'commonLabels' is deprecated. Please use 'labels' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'commonLabels' is deprecated. Please use 'labels' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'commonLabels' is deprecated. Please use 'labels' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'commonLabels' is deprecated. Please use 'labels' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'commonLabels' is deprecated. Please use 'labels' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'commonLabels' is deprecated. Please use 'labels' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'patchesStrategicMerge' is deprecated. Please use 'patches' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'vars' is deprecated. Please use 'replacements' instead. [EXPERIMENTAL] Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'patchesStrategicMerge' is deprecated. Please use 'patches' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'vars' is deprecated. Please use 'replacements' instead. [EXPERIMENTAL] Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'bases' is deprecated. Please use 'resources' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'commonLabels' is deprecated. Please use 'labels' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'patchesStrategicMerge' is deprecated. Please use 'patches' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'vars' is deprecated. Please use 'replacements' instead. [EXPERIMENTAL] Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'commonLabels' is deprecated. Please use 'labels' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'vars' is deprecated. Please use 'replacements' instead. [EXPERIMENTAL] Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'commonLabels' is deprecated. Please use 'labels' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'commonLabels' is deprecated. Please use 'labels' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'vars' is deprecated. Please use 'replacements' instead. [EXPERIMENTAL] Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'patchesStrategicMerge' is deprecated. Please use 'patches' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'bases' is deprecated. Please use 'resources' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'commonLabels' is deprecated. Please use 'labels' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'patchesJson6902' is deprecated. Please use 'patches' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'patchesStrategicMerge' is deprecated. Please use 'patches' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'commonLabels' is deprecated. Please use 'labels' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'patchesStrategicMerge' is deprecated. Please use 'patches' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'vars' is deprecated. Please use 'replacements' instead. [EXPERIMENTAL] Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'patchesStrategicMerge' is deprecated. Please use 'patches' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'bases' is deprecated. Please use 'resources' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'commonLabels' is deprecated. Please use 'labels' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'patchesStrategicMerge' is deprecated. Please use 'patches' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'commonLabels' is deprecated. Please use 'labels' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'patchesStrategicMerge' is deprecated. Please use 'patches' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'vars' is deprecated. Please use 'replacements' instead. [EXPERIMENTAL] Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'patchesStrategicMerge' is deprecated. Please use 'patches' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'commonLabels' is deprecated. Please use 'labels' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'commonLabels' is deprecated. Please use 'labels' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'vars' is deprecated. Please use 'replacements' instead. [EXPERIMENTAL] Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'patchesStrategicMerge' is deprecated. Please use 'patches' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'patchesStrategicMerge' is deprecated. Please use 'patches' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'bases' is deprecated. Please use 'resources' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'commonLabels' is deprecated. Please use 'labels' instead. Run 'kustomize edit fix' to update your Kustomization automatically.

Steps to Reproduce

kustomize build example.
see also kubeflow/katib#2511

You need to fix many of then in the appropiate upstream repository, not in our synchronizes upstream folders.

Screenshots or Videos (Optional)

No response
@juliusvonkohout juliusvonkohout added good first issue Good for newcomers help wanted Extra attention is needed labels Feb 13, 2025
@mahdikhashan
Copy link
Member

/assign

@mahdikhashan
Copy link
Member

mahdikhashan commented Feb 13, 2025 •
edited
Loading

@juliusvonkohout i'd like to help.

@juliusvonkohout
Copy link
Member Author

juliusvonkohout commented Feb 13, 2025 •
edited
Loading

@juliusvonkohout i'd like to help.

You can just start creating PRs. For the common components usually within kubeflow/manifests (there i can merge them fast for you so best start there) and for most things under "apps" in the specific working group repositories, e.g. kubeflow/pipelines. We then synchronize them back with the scripts in /hack.

And of course multiple contributors can work on this task in parallel and create PRs.

@mahdikhashan mahdikhashan mentioned this issue Feb 13, 2025
Merged
2 tasks
@juliusvonkohout
Copy link
Member Author

juliusvonkohout commented Feb 13, 2025 •
edited
Loading

@mahdikhashan thank you and congratulations to the merged PR for kserve-models-web-application

@mahdikhashan
Copy link
Member

Shall we reopen this issue for other components?

@juliusvonkohout
Copy link
Member Author

Shall we reopen this issue for other components?

yes

@juliusvonkohout juliusvonkohout added this to the 1.10 milestone Feb 13, 2025
This was referenced Feb 15, 2025
Closed
Open
@juliusvonkohout juliusvonkohout modified the milestones: 1.10, 1.10.1 Feb 17, 2025
@juliusvonkohout juliusvonkohout mentioned this issue Feb 18, 2025
Draft
7 tasks
@juliusvonkohout
Copy link
Member Author

juliusvonkohout commented Feb 18, 2025 •
edited
Loading

You can also continue in parallel with other components if some PRs are blocked by review.

@vikas-saxena02
Copy link

@juliusvonkohout @mahdikhashan everything under contrib/spark and contrib/ray looks good to me.

@vikas-saxena02
Copy link

contrib/seaweedfs is also good

@milinddethe15
Copy link
Contributor

@juliusvonkohout For each Kustomization.yaml in https://github.com/kubeflow/pipelines/tree/master/manifests/kustomize do we need to run kustomize edit fix ?

@juliusvonkohout
Copy link
Member Author

@juliusvonkohout For each Kustomization.yaml in https://github.com/kubeflow/pipelines/tree/master/manifests/kustomize do we need to run kustomize edit fix ?

You can run kustomize build and check where the warnings come from. If there is a warning you can run kustomize edit fix. But maybe you need manual changes as well such that diff -u is zero. Furthermore for all paths containing "upstream" you also have to raise a PR in the respective upstream repository.

@milinddethe15
Copy link
Contributor

/assign

@vikas-saxena02
Copy link

@milinddethe15 it's a big task so let's divide amongst ourselves.. let us know which directories are you are currently working on so that we can cut down on duplication of effort.

@milinddethe15
Copy link
Contributor

@vikas-saxena02 Thank you, I can do for top two starting directories: base, cluster-scoped-resources-tekton

@juliusvonkohout Are we using kustomize lastest version (5.6.0)?

@mahdikhashan
Copy link
Member

/unassign

@juliusvonkohout
Copy link
Member Author

@vikas-saxena02 Thank you, I can do for top two starting directories: base, cluster-scoped-resources-tekton

@juliusvonkohout Are we using kustomize lastest version (5.6.0)?

We are on 5.4 but I think you can test with 5.6 as well. The best thing is to prioritise the things from /example/kustomization.yaml

@vikas-saxena02
Copy link

@vikas-saxena02 Thank you, I can do for top two starting directories: base, cluster-scoped-resources-tekton

@juliusvonkohout Are we using kustomize lastest version (5.6.0)?

as per readme version 5.2.1+ can be used

Image

@juliusvonkohout
Copy link
Member Author

We currently use 5.4 in our cicd

@milinddethe15 milinddethe15 mentioned this issue Mar 2, 2025
Closed
2 tasks
@juliusvonkohout juliusvonkohout mentioned this issue Mar 6, 2025
Open
16 tasks
@milinddethe15 milinddethe15 mentioned this issue Mar 7, 2025
Draft
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@milinddethe15 milinddethe15

Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
1.10.1
Development

Successfully merging a pull request may close this issue.

fix warnings after kustomize build in contrib mahdikhashan/manifests
4 participants
@juliusvonkohout @mahdikhashan @vikas-saxena02 @milinddethe15