Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate away from deprecated github.com/hpcloud/tail #2299

Closed
AndersBennedsgaard opened this issue Apr 4, 2024 · 4 comments · Fixed by #2375
Closed

Migrate away from deprecated github.com/hpcloud/tail #2299

AndersBennedsgaard opened this issue Apr 4, 2024 · 4 comments · Fixed by #2375
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed kind/feature

Comments

@AndersBennedsgaard
Copy link

AndersBennedsgaard commented Apr 4, 2024

/kind feature

Describe the solution you'd like

As https://github.com/hpcloud/tail hasn't been touched for 6 years (it is using Go v1.5.1), and the https://github.com/hpcloud organisation doesn't have any (public) members, we should really stop depending on their code. Multiple forks has been created, but it seems like https://github.com/nxadm/tail is the most popular one, so this could be a potential candidate

Anything else you would like to add:

The reason I found this usage of a deprecated package, is that I hit #1769 and tried to investigate the issue


Love this feature? Give it a 👍 We prioritize the features with the most 👍

Copy link

github-actions bot commented Jul 3, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@andreyvelich
Copy link
Member

/help
/good-first-issue

Copy link

@andreyvelich:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/help
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@google-oss-prow google-oss-prow bot added good first issue Good for newcomers help wanted Extra attention is needed labels Jul 3, 2024
@tariq-hasan
Copy link
Contributor

I am interested to take on this one.

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed kind/feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants