Skip to content

Commit d1ea629

Browse files
committed
delete fetching pod logs
Signed-off-by: helenxie-bit <[email protected]>
1 parent 865379e commit d1ea629

File tree

2 files changed

+10
-28
lines changed

2 files changed

+10
-28
lines changed

.github/workflows/e2e-test-tune-api.yaml

-28
Original file line numberDiff line numberDiff line change
@@ -33,34 +33,6 @@ jobs:
3333
tune-api: true
3434
training-operator: true
3535

36-
- name: Fetch Pod Description and Logs for Experiment # This step is added to debug the test failure
37-
if: always()
38-
run: |
39-
echo "Fetching all the pods..."
40-
kubectl get pods -n default
41-
42-
POD_NAME_1=$(kubectl get pods -n default --no-headers -o custom-columns=":metadata.name" | grep tune-example-1 | grep master)
43-
44-
echo "Fetching pod description for tune-example-1..."
45-
kubectl describe pod $POD_NAME_1 -n default
46-
47-
echo "Fetching pod logs for tune-example-1..."
48-
kubectl logs $POD_NAME_1 -n default --all-containers
49-
50-
POD_NAME_2=$(kubectl get pods -n default --no-headers -o custom-columns=":metadata.name" | grep tune-example-2 | grep master)
51-
52-
echo "Fetching pod description for tune-example-2..."
53-
kubectl describe pod $POD_NAME_2 -n default
54-
55-
echo "Fetching pod logs for tune-example-2..."
56-
kubectl logs $POD_NAME_2 -n default --all-containers
57-
58-
- name: Delete Experiment for e2e test
59-
if: always()
60-
run: |
61-
kubectl delete experiment tune-example-1 -n default
62-
kubectl delete experiment tune-example-2 -n default
63-
6436
strategy:
6537
fail-fast: false
6638
matrix:

test/e2e/v1beta1/scripts/gh-actions/run-e2e-tune-api.py

+10
Original file line numberDiff line numberDiff line change
@@ -166,6 +166,11 @@ def run_e2e_experiment_create_by_tune_with_external_model(
166166
logging.info("---------------------------------------------------------------")
167167
logging.info(f"E2E is failed for Experiment created by tune: {exp_namespace}/{exp_name}-1")
168168
raise e
169+
finally:
170+
# Delete the Experiment.
171+
logging.info("---------------------------------------------------------------")
172+
logging.info("---------------------------------------------------------------")
173+
katib_client.delete_experiment(f"{exp_name}-1", exp_namespace)
169174

170175
try:
171176
run_e2e_experiment_create_by_tune_with_external_model(katib_client, f"{exp_name}-2", exp_namespace)
@@ -175,3 +180,8 @@ def run_e2e_experiment_create_by_tune_with_external_model(
175180
logging.info("---------------------------------------------------------------")
176181
logging.info(f"E2E is failed for Experiment created by tune: {exp_namespace}/{exp_name}-2")
177182
raise e
183+
finally:
184+
# Delete the Experiment.
185+
logging.info("---------------------------------------------------------------")
186+
logging.info("---------------------------------------------------------------")
187+
katib_client.delete_experiment(f"{exp_name}-2", exp_namespace)

0 commit comments

Comments
 (0)