Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Eliminate GCP key from chart #2767

Closed
2 tasks done
chipzoller opened this issue Nov 16, 2023 · 5 comments
Closed
2 tasks done

[Feature] Eliminate GCP key from chart #2767

chipzoller opened this issue Nov 16, 2023 · 5 comments
Labels
enhancement New feature or request stale

Comments

@chipzoller
Copy link
Collaborator

Problem Statement

The environment variable CLOUD_PROVIDER_API_KEY is present by default in the chart with a Kubecost-provided, hard-coded value. This is to increase user time-to-value and provide less work for them. However, this goes against basic security practices and as a result is being flagged and alerted on by various linters and scanners in CI. Defining sensitive information such as passwords, keys, and API tokens, even if deemed "safe" for public consumption, should be avoided.

Solution Description

Eliminate the hard-coded CLOUD_PROVIDER_API_KEY value and template allowing users to bring their own. Provide documentation instructing users on how to create a key with the required permissions.

Alternatives

No response

Additional Context

No response

Troubleshooting

  • I have read and followed the issue guidelines and this is a feature request only for the Helm chart.
  • I have searched other issues in this repository and mine is not recorded.
@chipzoller chipzoller added enhancement New feature or request needs-triage labels Nov 16, 2023
@ameijer
Copy link
Contributor

ameijer commented Nov 16, 2023

+1 here - this would also make our static code analysis tooling much happier, not having this

@chipzoller
Copy link
Collaborator Author

This issue depends on opencost/opencost#2311 before it can be implemented. Would likely require other chart-level changes as well.

@AjayTripathy
Copy link
Contributor

As a note, this would increase install friction since users would get default costs unless they add their key in to get public pricing for gcp nodes.

Copy link

This issue has been marked as stale because it has been open for 360 days with no activity. Please remove the stale label or comment or this issue will be closed in 5 days.

@github-actions github-actions bot added the stale label Feb 11, 2025
Copy link

This issue was closed because it has been inactive for 365 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
None yet
Development

No branches or pull requests

3 participants